-
Notifications
You must be signed in to change notification settings - Fork 3.2k
style: Menu expansion and collapse changed to regular display #8315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3100,6 +3100,8 @@ const message = { | |
| baseDir: 'インストールディレクトリ', | ||
| baseDirHelper: 'インストールディレクトリが空の場合、デフォルトで/optディレクトリにインストールされます', | ||
| nodePort: 'ノードポート', | ||
| offline: 'オフラインモード', | ||
| offlineHelper: 'ノードがオフライン環境にある場合に使用', | ||
| }, | ||
| customApp: { | ||
| name: 'カスタムアプリリポジトリ', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The given code difference looks mostly correct but might benefit from some minor adjustments:
Optimization Suggestion (optional): Overall, the changes seem well-intentioned and aligns with typical locale-specific translations. If further customization is needed, feel free to share additional details! |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,8 @@ | ||
| <template> | ||
| <div :class="classObj" class="app-wrapper" v-loading="loading" :element-loading-text="loadingText" fullscreen> | ||
| <div v-if="classObj.mobile && classObj.openSidebar" class="drawer-bg" @click="handleClickOutside" /> | ||
| <div | ||
| class="app-sidebar" | ||
| v-if="!globalStore.isFullScreen" | ||
| @mouseenter="collapseButtonShow = true" | ||
| @mouseleave="collapseButtonShow = false" | ||
| > | ||
| <el-affix v-if="collapseButtonShow" :offset="18" class="affix"> | ||
| <div class="app-sidebar" v-if="!globalStore.isFullScreen"> | ||
| <el-affix :offset="18" class="affix"> | ||
| <el-tooltip | ||
| :content="menuStore.isCollapse ? $t('commons.button.expand') : $t('commons.button.collapse')" | ||
| > | ||
|
|
@@ -48,7 +43,6 @@ import TaskList from '@/components/task-list/index.vue'; | |
| const { switchTheme } = useTheme(); | ||
|
|
||
| useResize(); | ||
| const collapseButtonShow = ref(); | ||
|
|
||
| const taskListRef = ref(); | ||
| const openTask = () => { | ||
|
|
@@ -81,7 +75,6 @@ const handleClickOutside = () => { | |
|
|
||
| const handleCollapse = () => { | ||
| menuStore.setCollapse(); | ||
| collapseButtonShow.value = false; | ||
| }; | ||
|
|
||
| watch( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here are some potential improvements and optimizations for the given code:
Remember: these changes will depend heavily on the rest of your app's structure and requirements. |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No significant issues were detected in the provided JavaScript code snippet you shared. However, there's one addition worth noting:
Ensure that all translations adhere to OpenAI's guidelines for consistency, such as using proper capitalization, accurate spellings, and consistent formatting.
Overall, the code remains clean and functional with no apparent errors. If further improvements or optimizations are needed beyond these additions, additional context or requirements would be necessary.