Skip to content

fix: Set bridge as the default network for container creation. #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Apr 7, 2025
Merged

fix: Set bridge as the default network for container creation. #8332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/views/container/container/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ const onOpenDialog = async (
rowData: Partial<Container.ContainerHelper> = {
cmd: [],
cmdStr: '',
network: 'bridge',
publishAllPorts: false,
exposedPorts: [],
cpuShares: 1024,
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is mostly clean and well-formatted. However, there are two minor areas that could be improved:

  1. Network Configuration: The default network value set to 'bridge' is generally considered sufficient in most contexts. However, if you have specific requirements or prefer a different network setup (e.g., Docker Swarm), you might want to introduce an option for users to select the desired network type.

  2. Initialization of Variables: While it's not strictly necessary to explicitly initialize these variables with values (cmd, cmdStr, etc.), this can help future developers understand the expected state when using the function without checking individual assignments later in the code. If no initial values are intended, you could omit them entirely.

Here's an example of how you might modify the code slightly for clarity:

const onOpenDialog = async (
  rowData: Partial<Container.ContainerHelper> | undefined = undefined,
): Promise<void> => {
  let rowData_: Container.ContainerHelper;
  
  // Initialize rowData_ if rowData was not provided
  if (!rowData) {
    rowData_ = { cmd: [], cmdStr: '', network: 'bridge', publishAllPorts: false, exposedPorts: [], cpuShares: 1024 };
  } else {
    rowData_ = rowData;
  }

  // Your other logic here...
};

These changes ensure that rowData defaults to initializing with known properties, enhancing readability and maintainability.

Expand Down
Loading