style: Fixed an issue with autofill style exceptions in dark backgrounds#8333
style: Fixed an issue with autofill style exceptions in dark backgrounds#8333f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| .el-input.is-disabled .el-input__wrapper { | ||
| --el-disabled-bg-color: var(--panel-main-bg-color-9); |
There was a problem hiding this comment.
There are some discrepancies and optimizations suggested in the provided code:
-
CSS Class Name Consistency: The class
.el-form-item .el-input__inner:-webkit-autofillshould be consistent across all stylesheets to avoid conflicts. -
Font Color Setting: While setting
-webkit-text-fill-colorfor autofilled input fields is generally useful, ensure it applies only when necessary to protect user data privacy. -
Performance Considerations:
- The animation effect with
transition: background-color 1000s ease-out 0.5s;might cause noticeable delays on pages that frequently change their backgrounds, especially if performance becomes an issue. - Consider using more efficient animations like
background-imagetransitions instead of color changes unless you specifically need visual updates during this duration.
- The animation effect with
Here's a slightly optimized version of the relevant section:
html.dark {
background-color: var(--panel-main-bg-color-1);
transition: background-color 0.5s ease-out 0.5s;
}
/* Ensure consistency */
.el-form-item {
/* Add other relevant styles here if needed */
}
/* Autofill text fill color (optional) */
:root { /* Adjust scope depending on where 'var(--el-text-color-regular)' comes from */
--el-text-color-regular: white; /* Choose a dark color if needed */
}
body [type="text"]:disabled,
input[type="text"]:disabled, /* Include disabled inputs too */
.input-group-text[data-status=editable]:disabled span.disabled-content {
/* Additional styles or classes for disabled fields */
}These updates address inconsistencies and offer some minor improvements while balancing readability and performance needs.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



No description provided.