Skip to content

style: Fixed an issue with autofill style exceptions in dark backgrounds #8333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Apr 7, 2025
Merged

style: Fixed an issue with autofill style exceptions in dark backgrounds #8333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/styles/element-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ html.dark {
background-color: var(--panel-main-bg-color-1);
transition: background-color 1000s ease-out 0.5s;
}
.el-form-item .el-input__inner:-webkit-autofill {
-webkit-text-fill-color: var(--el-text-color-regular) !important;
}

.el-input.is-disabled .el-input__wrapper {
--el-disabled-bg-color: var(--panel-main-bg-color-9);
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some discrepancies and optimizations suggested in the provided code:

  1. CSS Class Name Consistency: The class .el-form-item .el-input__inner:-webkit-autofill should be consistent across all stylesheets to avoid conflicts.

  2. Font Color Setting: While setting -webkit-text-fill-color for autofilled input fields is generally useful, ensure it applies only when necessary to protect user data privacy.

  3. Performance Considerations:

    • The animation effect with transition: background-color 1000s ease-out 0.5s; might cause noticeable delays on pages that frequently change their backgrounds, especially if performance becomes an issue.
    • Consider using more efficient animations like background-image transitions instead of color changes unless you specifically need visual updates during this duration.

Here's a slightly optimized version of the relevant section:

html.dark {
    background-color: var(--panel-main-bg-color-1);
    transition: background-color 0.5s ease-out 0.5s;
}

/* Ensure consistency */
.el-form-item {
    /* Add other relevant styles here if needed */
}

/* Autofill text fill color (optional) */
:root { /* Adjust scope depending on where 'var(--el-text-color-regular)' comes from */
    --el-text-color-regular: white; /* Choose a dark color if needed */
}

body [type="text"]:disabled,
input[type="text"]:disabled, /* Include disabled inputs too */
.input-group-text[data-status=editable]:disabled span.disabled-content {
    /* Additional styles or classes for disabled fields */
}

These updates address inconsistencies and offer some minor improvements while balancing readability and performance needs.

Expand Down
Loading