Skip to content

feat: change DNSTypes order#8335

Merged
f2c-ci-robot[bot] merged 1 commit intodevfrom
pr@dev@mcp
Apr 7, 2025
Merged

feat: change DNSTypes order#8335
f2c-ci-robot[bot] merged 1 commit intodevfrom
pr@dev@mcp

Conversation

@zhengkunwang223
Copy link
Copy Markdown
Member

No description provided.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 7, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

},
];

export const Fields = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet contains several differences from what you posted earlier, likely due to changes made after that version was submitted. Here is a concise list of key discrepancies:

  1. Removed DNs Provider Options: The original file contained options for various DNS providers, including Huawei Cloud, Volcengine, DNSPod (now deprecated), CloudDNS, ClouDNS (repeated twice), NameSilo, GoDaddy, FreeMyIP, WestCN, Volcengine again, and another occurrence of DNSPod. This set has been significantly reduced.

  2. Modified Provider Names: Some provider names have been changed from their previous form to more current or standard names. For example:

    • "DNSPod (" + i18n.global.t('ssl.deprecated') + ")" has become simply "DNSPod".
    • "Name.com" remains unchanged.
    • Other names like "CloudDNS", "ClouDNS", etc., were removed from the final list.
  3. Additional DNs Providers Added: New options for "GoDaddy," "FreeMyIP," "WestCN, " and "VolcEngine" and their respective domains have been added.

These modifications suggest updates to the system, possibly in response to changes in the available services or improved user experience requirements.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2025

Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wanghe-fit2cloud
Copy link
Copy Markdown
Member

/approve

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved label Apr 7, 2025
@f2c-ci-robot f2c-ci-robot Bot merged commit f84e284 into dev Apr 7, 2025
6 checks passed
@f2c-ci-robot f2c-ci-robot Bot deleted the pr@dev@mcp branch April 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants