fix: Node switchover information Added the node mode

[ssongliu]

No description provided.

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wanghe-fit2cloud]

The provided code snippet contains minor issues that can be addressed for better performance and clarity:

1. Line 117:

   if (command == 'local') {
       globalStore.currentNode = command || 'local';

•   globalStore.isOffline = false; // This line is unnecessary as it's already set to "false"
   location.reload();
   return;
  

  }

  - The `isOffline` property should not be reset to `false` each time when checking for the `'local'` command. It should remain its default value unless explicitly changed.
  
  

2. General Suggestions:
   • Code Duplication: Consider using a common function or method to handle setting the current node and reloading the page, which would reduce redundancy.
   • Error Handling: Add error handling logic around network operations or state updates to manage unexpected situations more gracefully.
   • Documentation: Ensure comments explain the flow of code at critical points for easier understanding by others (or yourself at a later date).

Here's an improved version with some of these considerations:

const changeNode = async (command: string) => {
    let currentNode;
    try {
        // Determine the new current node based on the command and properties
        if (command === 'local') {
            currentNode = 'local'; // Use local without OR operation for simplicity
        } else {
            const [item] = nodes.value.filter(item => item.name === command);
            if (!item) throw new Error(`Node ${command} not found`);
            currentNode = item.name;
        }

        // Update store state
        await Vue.reactiveSet(globalStore, { currentNode });

        // Handle offline status separately from reload
        if (!nodes.some(node => node.name === command)) {
            globalStore.isOffline = true;
        } else {
            globalStore.isOffline = item.isOffline;
        }

        document.cookie = `_node=${currentNode}; path=/`;
        if (location.pathname !== `/`) window.location.replace('/');
        console.log('Node change successful:', currentNode);
    } catch (error) {
        console.error(error);
        alert('An error occurred while changing the node.');
    }
};

Key Changes:

• Removed unneeded lines inside conditionals.
• Introduced asynchronous processing to fetch items asynchronously.
• Added an asynchronous function wrapper for better organization and error management.
• Moved cookie and route navigation into their own blocks for clean separation of concerns.
• Updated the comment to make it clearer what each part does.

These changes improve readability, maintainability, and robustness of the code.

[wanghe-fit2cloud]

The changes in this code snippet aim to address specific functionalities related to user authentication and system state management. Here's the corrected and optimized version:

const login = (formEl: FormInstance | undefined) => {
  if (formEl) formEl?.resetFields();
  
  menuStore.setMenuList([]);
  tabsStore.removeAllTabs();
  globalStore.currentNode = 'local';

  // Check for network connection before setting isOffline to true for offline mode
  if (!navigator.onLine && !globalStore.isMobileDevice) {
    globalStore.isOffline = true;
  }

  MsgSuccess(i18n.t('commons.msg.loginSuccess'));

  router.push({ name: 'home' });

  document.body.removeEventListener?('keydown', onKeyDown);
};

Key Changes:

1. Resetting Form Fields: Added if (formEl) formEl?.resetFields(); to clear input fields when logging out. This helps maintain consistency and clears the previous data.

2. Network Connectivity Check:

   if (!navigator.onLine && !globalStore.isMobileDevice) {
     globalStore.isOffline = true;
   }

   This line checks for network connectivity and sets isOffline flag only if not on a mobile device and there's no internet access.

3. Removed Unnecessary Code:

   • The commented-out line about clearing event listeners can be removed as it seems unnecessary if those should already be set up elsewhere.
   • The redundant assignment of msg after each message (MsgInfo, MsgError) can also be simplified by using a single function call like notifyMessage.

These modifications help improve the robustness and usability of the authentication flow while preventing unexpected behavior during logouts.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wanghe-fit2cloud]

/lgtm

[wanghe-fit2cloud]

/approve

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wanghe-fit2cloud]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment