Skip to content

fix: Fix the problem of failed backup of all databases for cronjob #8990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Jun 10, 2025
Merged

fix: Fix the problem of failed backup of all databases for cronjob #8990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent/app/service/cronjob_backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ func loadDbsForJob(cronjob model.Cronjob) []DatabaseHelper {
dbs = append(dbs, DatabaseHelper{
ID: mysql.ID,
DBType: cronjob.DBType,
Database: mysql.Name,
Database: mysql.Database,
Name: mysql.Name,
})
}
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct and optimized with no immediate irregularities or potential issues. The change from mysql.Name to mysql.Database maintains consistency but does not appear necessary unless you have specific requirements that dictate using different names for databases versus IDs. If both columns should be used, the code is already correctly handling this scenario.

Expand Down
Loading