Skip to content

feat: Approval detail#2255

Merged
fit2-zhao merged 1 commit into
mainfrom
pr@main@feat_approval_detail
May 15, 2026
Merged

feat: Approval detail#2255
fit2-zhao merged 1 commit into
mainfrom
pr@main@feat_approval_detail

Conversation

@fit2-zhao

Copy link
Copy Markdown
Member

feat: Approval detail

@f2c-ci-robot

f2c-ci-robot Bot commented May 15, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot

f2c-ci-robot Bot commented May 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign song-cc-rock for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fit2-zhao fit2-zhao force-pushed the pr@main@feat_approval_detail branch from 257c138 to 84ca8bc Compare May 15, 2026 08:44
@song-cc-rock song-cc-rock force-pushed the pr@main@feat_approval_detail branch from 84ca8bc to ab708eb Compare May 15, 2026 09:27
@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0.71429% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.22%. Comparing base (0f4453b) to head (ab708eb).
⚠️ Report is 598 commits behind head on main.

Files with missing lines Patch % Lines
.../crm/approval/service/ApprovalInstanceService.java 0.00% 65 Missing ⚠️
.../crm/approval/service/ApprovalResourceService.java 4.76% 20 Missing ⚠️
...ys/crm/approval/service/ApprovalActionService.java 0.00% 19 Missing ⚠️
...s/crm/contract/service/ContractInvoiceService.java 0.00% 9 Missing ⚠️
...n/cordys/crm/contract/service/ContractService.java 0.00% 9 Missing ⚠️
...portunity/service/OpportunityQuotationService.java 0.00% 9 Missing ⚠️
...n/cordys/crm/system/service/UserExtendService.java 0.00% 5 Missing ⚠️
...rdys/crm/approval/service/ApprovalFlowService.java 0.00% 2 Missing ⚠️
.../cordys/crm/approval/aspect/HitApprovalAspect.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2255      +/-   ##
============================================
- Coverage     33.29%   33.22%   -0.07%     
- Complexity     1946     2252     +306     
============================================
  Files           382      425      +43     
  Lines         21892    25589    +3697     
  Branches       2309     2734     +425     
============================================
+ Hits           7289     8503    +1214     
- Misses        14042    16366    +2324     
- Partials        561      720     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fit2-zhao fit2-zhao merged commit 29176cb into main May 15, 2026
5 of 8 checks passed
@fit2-zhao fit2-zhao deleted the pr@main@feat_approval_detail branch May 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants