Skip to content

fix: resource approval for review and revoke #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fit2-zhao merged 1 commit into from
May 18, 2026
Merged

fix: resource approval for review and revoke #2268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions frontend/packages/web/src/hooks/useApprovalResourceAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,31 @@ interface ApprovalResourceActionHandlers {

interface UseApprovalResourceActionOptions {
formKey: FormDesignKeyEnum;
preventDuplicateByResourceId?: boolean;
}

export default function useApprovalResourceAction(options: UseApprovalResourceActionOptions) {
const { t } = useI18n();
const Message = useMessage();

const enableDuplicateGuard = options.preventDuplicateByResourceId ?? true;

const reviewLoading = ref(false);
const revokeLoading = ref(false);
const reviewPendingResourceIds = new Set<string>();
const revokePendingResourceIds = new Set<string>();

async function submitReview(resourceId: string, callback?: ApprovalResourceActionHandlers) {
if (!resourceId) {
return;
}

if (enableDuplicateGuard && reviewPendingResourceIds.has(resourceId)) {
return;
}

try {
reviewPendingResourceIds.add(resourceId);
reviewLoading.value = true;
await reviewResource({
resourceId,
Expand All @@ -39,6 +49,7 @@ export default function useApprovalResourceAction(options: UseApprovalResourceAc
// eslint-disable-next-line no-console
console.error(error);
} finally {
reviewPendingResourceIds.delete(resourceId);
reviewLoading.value = false;
}
}
Expand All @@ -48,7 +59,12 @@ export default function useApprovalResourceAction(options: UseApprovalResourceAc
return;
}

if (enableDuplicateGuard && revokePendingResourceIds.has(resourceId)) {
return;
}

try {
revokePendingResourceIds.add(resourceId);
revokeLoading.value = true;
await revokeResource({
resourceId,
Expand All @@ -61,6 +77,7 @@ export default function useApprovalResourceAction(options: UseApprovalResourceAc
// eslint-disable-next-line no-console
console.error(error);
} finally {
revokePendingResourceIds.delete(resourceId);
revokeLoading.value = false;
}
}
Expand Down
Loading