Skip to content

refactor: approval attachment check#2284

Merged
fit2-zhao merged 1 commit into
mainfrom
pr@main@refactor_approval_attachment_check
May 18, 2026
Merged

refactor: approval attachment check#2284
fit2-zhao merged 1 commit into
mainfrom
pr@main@refactor_approval_attachment_check

Conversation

@fit2-zhao
Copy link
Copy Markdown
Member

No description provided.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 18, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign song-cc-rock for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.95%. Comparing base (0f4453b) to head (665acd2).
⚠️ Report is 618 commits behind head on main.

Files with missing lines Patch % Lines
...ys/crm/approval/service/ApprovalActionService.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2284      +/-   ##
============================================
- Coverage     33.29%   32.95%   -0.34%     
- Complexity     1946     2241     +295     
============================================
  Files           382      425      +43     
  Lines         21892    25707    +3815     
  Branches       2309     2768     +459     
============================================
+ Hits           7289     8473    +1184     
- Misses        14042    16516    +2474     
- Partials        561      718     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fit2-zhao fit2-zhao merged commit b74f276 into main May 18, 2026
8 of 11 checks passed
@fit2-zhao fit2-zhao deleted the pr@main@refactor_approval_attachment_check branch May 18, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants