From 665acd275eac1aa34a52215509501cb6c2f8982c Mon Sep 17 00:00:00 2001
From: WangXu10 <xu.wang@fit2cloud.com>
Date: Mon, 18 May 2026 18:13:11 +0800
Subject: [PATCH] refactor: approval attachment check

---
 .../crm/approval/service/ApprovalActionService.java  | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/backend/crm/src/main/java/cn/cordys/crm/approval/service/ApprovalActionService.java b/backend/crm/src/main/java/cn/cordys/crm/approval/service/ApprovalActionService.java
index 945aa4ef3a..2b7ccd91d3 100644
--- a/backend/crm/src/main/java/cn/cordys/crm/approval/service/ApprovalActionService.java
+++ b/backend/crm/src/main/java/cn/cordys/crm/approval/service/ApprovalActionService.java
@@ -87,7 +87,9 @@ public void sign(ApprovalAddSignRequest request, String userId, String orgId) {
 			handleNextApprovalNode(nextNode, instance, userId);
 		}
 		// 保存加签附件
-		saveInstanceAttachment(request.getAttachmentIds(), request.getInstanceId(), addSignTask.getId(), userId, orgId);
+		if (CollectionUtils.isNotEmpty(request.getAttachmentIds())) {
+			saveInstanceAttachment(request.getAttachmentIds(), request.getInstanceId(), addSignTask.getId(), userId, orgId);
+		}
 	}
 
 	/**
@@ -105,7 +107,9 @@ public void back(ApprovalReturnBackRequest request, String userId, String orgId)
 		// 保存执行任务
 		saveActionTask(request, ApprovalAction.BACK, userId, orgId, null);
 		// 保存退回附件
-		saveInstanceAttachment(request.getAttachmentIds(), request.getInstanceId(), backRecord.getId(), userId, orgId);
+		if (CollectionUtils.isNotEmpty(request.getAttachmentIds())) {
+			saveInstanceAttachment(request.getAttachmentIds(), request.getInstanceId(), backRecord.getId(), userId, orgId);
+		}
 	}
 
 	/**
@@ -296,7 +300,9 @@ private void saveApprovalRecord(ApprovalTask currentTask, String comment, List<S
 		record.setUpdateTime(System.currentTimeMillis());
 		record.setUpdateUser(currentUserId);
 		approvalRecordMapper.insert(record);
-		saveInstanceAttachment(attachmentIds, currentTask.getInstanceId(), record.getId(), currentUserId, orgId);
+		if (CollectionUtils.isNotEmpty(attachmentIds)) {
+			saveInstanceAttachment(attachmentIds, currentTask.getInstanceId(), record.getId(), currentUserId, orgId);
+		}
 	}
 
 	/**