Skip to content

Commit 0a44243

Browse files
committed
feat: Determine need redeploy
1 parent 19acefe commit 0a44243

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

apps/trigger/serializers/task_source_trigger.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,16 +126,20 @@ def edit(self, instance: Dict, with_valid=True):
126126
if not trigger:
127127
raise serializers.ValidationError(_('Trigger not found'))
128128
task_source_trigger_edit_field_list = ['name', 'desc', 'trigger_type', 'trigger_setting', 'meta']
129+
trigger_deploy_edit_field_list = ['trigger_type', 'trigger_setting']
130+
131+
need_redeploy = any(field in instance for field in trigger_deploy_edit_field_list)
129132

130133
for field in task_source_trigger_edit_field_list:
131134
if field in valid_data:
132135
setattr(trigger, field, valid_data.get(field))
133136
trigger.save()
134137

135-
if trigger.is_active:
136-
deploy(ToolModelSerializer(trigger).data, **{})
137-
else:
138-
undeploy(TriggerModelSerializer(trigger).data, **{})
138+
if need_redeploy:
139+
if trigger.is_active:
140+
deploy(ToolModelSerializer(trigger).data, **{})
141+
else:
142+
undeploy(TriggerModelSerializer(trigger).data, **{})
139143

140144
return self.one()
141145

0 commit comments

Comments
 (0)