Skip to content

Commit 3ab157a

Browse files
committed
chore: remove RedisLock usage in scheduled_trigger.py for simplified deployment logic
1 parent 793bbc3 commit 3ab157a

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

apps/trigger/handler/impl/trigger/scheduled_trigger.py

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
from django.db.models import QuerySet
44

5-
from common.utils.lock import RedisLock
65
from common.utils.logger import maxkb_logger
76
from ops import celery_app
87
from trigger.handler.base_trigger import BaseTrigger
@@ -236,26 +235,9 @@ def deploy(self, trigger, **kwargs):
236235
self.undeploy(trigger, **kwargs)
237236
return
238237

239-
rlock = RedisLock()
240-
lock_key = f"scheduled_trigger_deploy:{trigger_id}"
241-
if not rlock.try_lock(lock_key, 30):
242-
return
243-
244-
try:
245-
maxkb_logger.debug(f"get lock {lock_key}")
246-
deploy_scheduled_trigger.delay(trigger, trigger_tasks, setting, schedule_type)
247-
finally:
248-
rlock.un_lock(lock_key)
238+
deploy_scheduled_trigger.delay(trigger, trigger_tasks, setting, schedule_type)
249239

250240
def undeploy(self, trigger, **kwargs):
251241
trigger_id = str(trigger["id"])
252242

253-
rlock = RedisLock()
254-
lock_key = f"scheduled_trigger_deploy:{trigger_id}"
255-
if not rlock.try_lock(lock_key, 30):
256-
return
257-
258-
try:
259-
_remove_trigger_jobs.delay(trigger_id)
260-
finally:
261-
rlock.un_lock(lock_key)
243+
_remove_trigger_jobs.delay(trigger_id)

0 commit comments

Comments
 (0)