feat: Edit trigger

Author: zhanweizhang7

apps/trigger/api/trigger.py

@@ -8,6 +8,7 @@
 """
 from drf_spectacular.types import OpenApiTypes
 from drf_spectacular.utils import OpenApiParameter
+from rest_framework import serializers
 
 from common.mixins.api_mixin import APIMixin
 from trigger.serializers.trigger import TriggerCreateRequest, TriggerResponse
@@ -61,4 +62,11 @@ def get_request():
 
     @staticmethod
     def get_response():
-        return TriggerResponse
+        return TriggerResponse
+class RequestSE(serializers.Serializer):
+        pass
+
+class TriggerEditAPI(APIMixin):
+    @staticmethod
+    def get_request():
+        return TriggerCreateRequest

apps/trigger/serializers/trigger.py

@@ -6,6 +6,7 @@
     @date：2026/1/14 11:48
     @desc:
 """
+from typing import Dict
 
 import uuid_utils.compat as uuid
 from django.db import models, transaction
@@ -24,6 +25,12 @@ class TriggerTaskCreateRequest(serializers.Serializer):
     source_type = serializers.ChoiceField(required=True, choices=TriggerTaskTypeChoices)
     source_id = serializers.CharField(required=True, label=_('source_id'))
     is_active = serializers.BooleanField(required=False, label=_('Is active'))
+    meta = models.JSONField(default=dict)
+    parameter = serializers.ListField(
+        child=serializers.DictField(),
+        required=False,
+        default=list
+    )
 
 
 class TriggerCreateRequest(serializers.Serializer):
@@ -158,21 +165,25 @@ def _validate_event_setting(setting):
                 'trigger_setting': 'body must be an array'
             })
 
+
 class TriggerModelSerializer(serializers.ModelSerializer):
     class Meta:
         model = Trigger
         fields = "__all__"
 
+
 class TriggerTaskModelSerializer(serializers.ModelSerializer):
     class Meta:
         model = TriggerTask
         fields = "__all__"
 
+
 class ApplicationTriggerTaskSerializer(serializers.ModelSerializer):
     class Meta:
         model = Application
         fields = ['id', 'name', 'work_flow', 'icon', 'type']
 
+
 class ToolTriggerTaskSerializer(serializers.ModelSerializer):
     class Meta:
         model = Tool
@@ -213,7 +224,7 @@ def insert(self, instance, with_valid=True):
         trigger_tasks = instance.get('trigger_task')
         if trigger_tasks:
             trigger_task_models = [
-                self.to_trigger_task_model(trigger_id, task.get('source_type'), task.get('source_id')) for task in
+                self.to_trigger_task_model(trigger_id, task) for task in
                 trigger_tasks
             ]
             TriggerTask.objects.bulk_create(trigger_task_models)
@@ -223,13 +234,15 @@ def insert(self, instance, with_valid=True):
         return TriggerResponse(trigger_model).data
 
     @staticmethod
-    def to_trigger_task_model(trigger_id: str, source_type: str, source_id: str):
+    def to_trigger_task_model(trigger_id: str, task_data: dict):
         return TriggerTask(
             id=uuid.uuid7(),
             trigger_id=trigger_id,
-            source_type=source_type,
-            source_id=source_id,
-            is_active=False
+            source_type=task_data.get('source_type'),
+            source_id=task_data.get('source_id'),
+            is_active=task_data.get('is_active', False),
+            parameter=task_data.get('parameter', []),
+            meta=task_data.get('meta', {})
         )
 
 
@@ -247,8 +260,39 @@ def is_valid(self, *, raise_exception=False):
         if not query_set.exists():
             raise AppApiException(500, _('Trigger id does not exist'))
 
-    def edit(self):
-        pass
+    @transaction.atomic
+    def edit(self, instance: Dict, with_valid=True):
+        if with_valid:
+            self.is_valid()
+            TriggerCreateRequest(data=instance).is_valid(raise_exception=True)
+        trigger_id = self.data.get('trigger_id')
+        trigger = Trigger.objects.filter(id=trigger_id).first()
+        if not trigger:
+            raise serializers.ValidationError(_('Trigger not found'))
+
+        trigger_edit_field_list = ['name', 'desc', 'trigger_type', 'trigger_setting', 'meta', 'is_active']
+
+        for field in trigger_edit_field_list:
+            if field in instance:
+                trigger.__setattr__(field, instance.get(field))
+        trigger.save()
+        # 处理trigger task
+        TriggerTask.objects.filter(trigger_id=trigger_id).delete()
+        trigger_tasks = instance.get('trigger_task')
+        if trigger_tasks:
+            trigger_task_model_list = [TriggerTask(
+                id=uuid.uuid7(),
+                trigger_id=trigger_id,
+                source_type=task_data.get('source_type'),
+                source_id=task_data.get('source_id'),
+                is_active=task_data.get('is_active', False),
+                parameter=task_data.get('parameter', []),
+                meta=task_data.get('meta', {})
+            ) for task_data in trigger_tasks]
+            TriggerTask.objects.bulk_create(trigger_task_model_list)
+        else:
+            raise AppApiException(500, _('Trigger task can not be empty'))
+        return self.one(with_valid=False)
 
     def one(self, with_valid=True):
         if with_valid:
@@ -257,21 +301,22 @@ def one(self, with_valid=True):
         trigger = QuerySet(Trigger).filter(id=trigger_id).first()
 
         trigger_tasks = QuerySet(TriggerTask).filter(trigger_id=trigger_id)
-        application_ids = [str(task.source_id) for task in trigger_tasks if task.source_type == TriggerTaskTypeChoices.APPLICATION]
+        application_ids = [str(task.source_id) for task in trigger_tasks if
+                           task.source_type == TriggerTaskTypeChoices.APPLICATION]
         tool_ids = [str(task.source_id) for task in trigger_tasks if task.source_type == TriggerTaskTypeChoices.TOOL]
 
-
         application_task_list = [ApplicationTriggerTaskSerializer(application).data for application in
-                            QuerySet(Application).filter(id__in=application_ids)]
+                                 QuerySet(Application).filter(id__in=application_ids)]
 
         tool_task_list = [ToolTriggerTaskSerializer(tool).data for tool in QuerySet(Tool).filter(id__in=tool_ids)]
 
         return {
             **TriggerModelSerializer(trigger).data,
-            'application_task_list':application_task_list,
-            'tool_task_list':tool_task_list,
+            'application_task_list': application_task_list,
+            'tool_task_list': tool_task_list,
         }
 
+
 class TriggerQuerySerializer(serializers.Serializer):
     name = serializers.CharField(required=False, allow_null=True, allow_blank=True, label=_('Trigger name'))
     type = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_('Trigger type'))

apps/trigger/views/trigger.py

@@ -8,6 +8,7 @@
 """
 from django.utils.translation import gettext_lazy as _
 from drf_spectacular.utils import extend_schema
+from rest_framework import serializers
 from rest_framework.request import Request
 from rest_framework.views import APIView
 
@@ -19,7 +20,7 @@
 from common.constants.permission_constants import PermissionConstants, RoleConstants, ViewPermission, CompareConstants
 from common.log.log import log
 from tools.api.tool import GetInternalToolAPI
-from trigger.api.trigger import TriggerCreateAPI, TriggerOperateAPI
+from trigger.api.trigger import TriggerCreateAPI, TriggerOperateAPI, TriggerEditAPI
 from trigger.serializers.trigger import TriggerSerializer
 
 
@@ -72,6 +73,24 @@ def get(self, request: Request, workspace_id: str, trigger_id: str):
                 data={'trigger_id': trigger_id, 'workspace_id': workspace_id,'user_id': request.user.id}
             ).one())
 
+        @extend_schema(
+            methods=['PUT'],
+            description=_('Modify the trigger'),
+            summary=_('Modify the trigger'),
+            operation_id=_('Modify the trigger'),  # type: ignore
+            parameters=TriggerOperateAPI.get_parameters(),
+            request=TriggerEditAPI.get_request(),
+            responses=result.DefaultResultSerializer,
+            tags=[_('Trigger')]  # type: ignore
+        )
+        def put(self, request: Request, workspace_id: str, trigger_id: str):
+            return result.success(TriggerOperateSerializer(
+                data={'trigger_id': trigger_id, 'workspace_id': workspace_id, 'user_id': request.user.id}
+            ).edit(request.data))
+
+
+
+
 
     class Page(APIView):
         authentication_classes = [TokenAuth]