Skip to content

Commit 8af2c73

Browse files
committed
fix: Query name error on trigger table and sql
1 parent 7e0e08b commit 8af2c73

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

apps/trigger/serializers/trigger.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,23 +82,19 @@ def validate_user_input_field_list(self, value):
8282

8383

8484
class ToolTaskParameterSerializer(serializers.Serializer):
85-
input_field_list = serializers.JSONField(required=False)
8685

87-
def validate_input_field_list(self, value):
88-
if not value:
89-
return value
90-
if not isinstance(value, dict):
91-
raise serializers.ValidationError(_("input_field_list must be a dict"))
86+
def to_internal_value(self, data):
87+
if not isinstance(data, dict):
88+
raise serializers.ValidationError("must be a dict")
9289

93-
for key, val in value.items():
90+
validated = {}
91+
for key, val in data.items():
9492
serializer = InputField(data=val)
9593
if not serializer.is_valid():
96-
raise serializers.ValidationError({
97-
key: serializer.errors
98-
})
99-
100-
return value
94+
raise serializers.ValidationError({key: serializer.errors})
95+
validated[key] = serializer.validated_data
10196

97+
return validated
10298

10399
class TriggerValidationMixin:
104100

@@ -607,7 +603,7 @@ class TriggerQuerySerializer(serializers.Serializer):
607603
def get_query_set(self):
608604
trigger_query_set = QuerySet(
609605
model=get_dynamics_model({
610-
'name': models.CharField(),
606+
't.name': models.CharField(),
611607
'trigger_type': models.CharField(),
612608
't.workspace_id': models.CharField(),
613609
't.is_active': models.BooleanField(),
@@ -618,7 +614,7 @@ def get_query_set(self):
618614
}))
619615
trigger_query_set = trigger_query_set.filter(**{'t.workspace_id': self.data.get("workspace_id")})
620616
if self.data.get("name"):
621-
trigger_query_set = trigger_query_set.filter(name__contains=self.data.get("name"))
617+
trigger_query_set = trigger_query_set.filter(**{'t.name__icontains': self.data.get("name")})
622618
if self.data.get("type"):
623619
trigger_query_set = trigger_query_set.filter(trigger_type=self.data.get("type"))
624620
if self.data.get("is_active") is not None:

apps/trigger/sql/get_trigger_page_list.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ WITH scheduler AS (SELECT SPLIT_PART(id, ':', 2) as trigger_id,
22
id,
33
next_run_time
44
FROM django_apscheduler_djangojob
5-
WHERE id LIKE 'trigger:%')
5+
WHERE id LIKE 'trigger:%%')
66
SELECT *
77
FROM (SELECT t.id,
88
t.workspace_id,

0 commit comments

Comments
 (0)