Skip to content

Commit c0c2966

Browse files
committed
fix: [Trigger] Trigger execution record list, missing type filtering
1 parent 172a6af commit c0c2966

File tree

5 files changed

+33
-2
lines changed

5 files changed

+33
-2
lines changed

apps/trigger/serializers/trigger_task.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ class TriggerTaskRecordQuerySerializer(serializers.Serializer):
127127
workspace_id = serializers.CharField(required=False, allow_null=True, allow_blank=True, label=_("Workspace ID"))
128128
state = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_('Trigger state'))
129129
name = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_('Trigger name'))
130+
source_type = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_('Source type'))
130131
order = serializers.CharField(required=False, allow_null=True, allow_blank=True, label=_('Order field'))
131132

132133
def is_valid(self, *, raise_exception=False):
@@ -146,6 +147,7 @@ def get_query_set(self):
146147
'sdc.name': models.CharField(),
147148
'ett.workspace_id': models.CharField(),
148149
'ett.trigger_id': models.UUIDField(),
150+
'sdc.source_type': models.CharField()
149151
}))
150152
trigger_query_set = trigger_query_set.filter(
151153
**{'ett.trigger_id': self.data.get("trigger_id")})
@@ -157,6 +159,8 @@ def get_query_set(self):
157159
trigger_query_set = trigger_query_set.filter(**{'ett.state': self.data.get('state')})
158160
if self.data.get("name"):
159161
trigger_query_set = trigger_query_set.filter(**{'sdc.name__contains': self.data.get('name')})
162+
if self.data.get('source_type'):
163+
trigger_query_set = trigger_query_set.filter(**{'sdc.source_type': self.data.get('source_type')})
160164
return trigger_query_set
161165

162166
def list(self, with_valid=True):

apps/trigger/views/trigger_task.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
from drf_spectacular.utils import extend_schema
1111
from rest_framework.request import Request
1212
from rest_framework.views import APIView
13+
14+
from common.auth import TokenAuth
1315
from common.auth.authentication import has_permissions
1416
from common import result
1517
from trigger.api.trigger_task import TriggerTaskRecordExecutionDetailsAPI, TriggerTaskRecordPageAPI, TriggerTaskAPI
@@ -20,6 +22,8 @@
2022

2123

2224
class TriggerTaskView(APIView):
25+
authentication_classes = [TokenAuth]
26+
2327
@extend_schema(
2428
methods=['GET'],
2529
description=_('Get the task list of triggers'),
@@ -43,6 +47,8 @@ class TriggerTaskRecordView(APIView):
4347

4448

4549
class TriggerTaskRecordExecutionDetailsView(APIView):
50+
authentication_classes = [TokenAuth]
51+
4652
@extend_schema(
4753
methods=['GET'],
4854
description=_('Retrieve detailed records of tasks executed by the trigger.'),
@@ -66,6 +72,8 @@ def get(self, request: Request, workspace_id: str, trigger_id: str, trigger_task
6672

6773

6874
class TriggerTaskRecordPageView(APIView):
75+
authentication_classes = [TokenAuth]
76+
6977
@extend_schema(
7078
methods=['GET'],
7179
description=_('Get a paginated list of execution records for trigger tasks.'),
@@ -83,6 +91,7 @@ def get(self, request: Request, workspace_id: str, trigger_id: str, current_page
8391
return result.success(
8492
TriggerTaskRecordQuerySerializer(
8593
data={'workspace_id': workspace_id, 'trigger_id': trigger_id,
94+
'source_type': request.query_params.get('source_type'),
8695
'state': request.query_params.get('state'),
8796
'name': request.query_params.get('name')})
8897
.page(current_page, page_size))

ui/src/locales/lang/zh-CN/common.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,6 @@ export default {
147147
ExecutionRecord: {
148148
title: '执行记录',
149149
subTitle: '查看执行记录',
150-
}
150+
},
151+
sourceType: '资源类型',
151152
}

ui/src/locales/lang/zh-Hant/common.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,5 @@ export default {
147147
title: '執行記錄',
148148
subTitle: '查看執行記錄',
149149
},
150+
sourceType: '資源類型',
150151
}

ui/src/views/trigger/execution-record/TriggerTaskRecordDrawer.vue

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
>
1717
<el-option :label="$t('common.name')" value="name" />
1818
<el-option :label="$t('common.status.label')" value="state" />
19+
<el-option :label="$t('common.sourceType')" value="source_type" />
1920
</el-select>
2021
<el-input
2122
v-if="searchType === 'name'"
@@ -25,6 +26,21 @@
2526
clearable
2627
@change="getList(true)"
2728
/>
29+
<el-select
30+
v-else-if="searchType === 'source_type'"
31+
v-model="query.source_type"
32+
@change="getList(true)"
33+
filterable
34+
clearable
35+
:reserve-keyword="false"
36+
collapse-tags
37+
collapse-tags-tooltip
38+
style="width: 220px"
39+
:placeholder="$t('common.search')"
40+
>
41+
<el-option :label="$t('views.application.title')" value="APPLICATION" />
42+
<el-option :label="$t('views.tool.title')" value="TOOL" />
43+
</el-select>
2844
<el-select
2945
v-else-if="searchType === 'state'"
3046
v-model="query.state"
@@ -172,6 +188,7 @@ const tableData = ref<Array<any>>([])
172188
const query = ref<any>({
173189
state: '',
174190
name: '',
191+
source_type: '',
175192
order: '',
176193
})
177194
const loading = ref<boolean>(false)
@@ -222,7 +239,6 @@ const getList = (isLoading?: boolean) => {
222239
} else return Promise.resolve()
223240
}
224241
225-
226242
const pre_disable = computed(() => {
227243
const index = tableData.value.findIndex((item) => item.id === currentId.value)
228244
return index === 0 && paginationConfig.current_page === 1

0 commit comments

Comments
 (0)