Skip to content

fix: The newly created simple application dialogue process label is not effective#2485

Merged
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_simple_application
Mar 4, 2025
Merged

fix: The newly created simple application dialogue process label is not effective#2485
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_simple_application

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: The newly created simple application dialogue process label is not effective

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 4, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

max_length=256,
error_messages=ErrMessage.char(_("End of thinking process marker")))


Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the reasoning_content_start field: it now uses <think> by default instead of {"start": "<think>"}. This could lead to unexpected behavior if this value were required at runtime or if other parts of your application expect {"start": "<think>"} directly.

To resolve this, you should change the default value back to {"start": "<think>"}:

        reasoning_content_start = serializers.CharField(required=False, allow_null=True, 
                                                      default={"start": "<think>"},
                                                       allow_blank=True, max_length=256,
                                                      error_messages=ErrMessage.char(_("The thinking process begins to mark")))

Also, ensure there are no similar issues with other fields that might have default values affecting expected data integrity.

@shaohuzhang1 shaohuzhang1 merged commit a75eb9f into main Mar 4, 2025
4 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_simple_application branch March 4, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant