fix: Setting avatar save prompt error(#2523)

[wangdan-fit2cloud]

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

• Made sure tests are passing and test coverage is added if needed.
• Made sure commit message follow the rule of Conventional Commits specification.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The code you provided has several potential issues that could be addressed:

1. Lack of Consistent Error Handling: There is no error handling in case something goes wrong during API requests (asyncPutApplication or overviewApi.putAppIcon). This can result in unexpected behavior if the server responds with errors.

2. Use of Raw File Data: The line fd.append('file', iconFile.value.raw) assumes that iconFile.value.raw already contains the raw data from the file input element, which might not always be reliable depending on the browser's implementation. It would be safer to work directly with the file object without assuming its raw property exists.

3. Redundant Code Blocks: Both conditions for setting an avatar use similar logic, including appending a form data entry and updating dialogVisible. These blocks could be extracted into a separate function to reduce redundancy.

4. Variable Naming: Variable names like defaultIcon, radioType, etc., should be more descriptive if possible, especially since they refer to user-facing elements.

Here’s a modified version of the code addressing some of these points:

function saveAvatar() {
    const id = id as string; // Assuming id is defined somewhere in scope

    const uploadImage = async () => {
        try {
            await appApi.uploadAppIcon(id, iconFile.value);
            emit('refresh');
            MsgSuccess(t('common.saveSuccess'));
            dialogVisible.value = false;
        } catch (error) {
            console.error("Failed to set Avatar:", error);
        }
    };

    if (radioType.value === 'default') {
        uploadImage();
    } else if (radioType.value === 'custom' && iconFile.value) {
        uploadImage();
    }
}

// In your main application component, call this function when you want to save the avatar

Key Changes:

• Function Extraction: The upload logic is now inside the saveAvatar function to prevent duplication.
• Error Handling: Added a generic error handler using a promise catch block to ensure any failed uploads are logged.
• Consistent Error Message: Replaced the success message specific to the Avatar Dialog with a common "Save Success" message.

This refactored version improves maintainability and robustness by encapsulating the core functionality in one place and providing better feedback on potential failures.