Skip to content

perf: Prompt word alignment issue(#2537) #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangdan-fit2cloud merged 1 commit into from
Mar 26, 2025
Merged

perf: Prompt word alignment issue(#2537) #2690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/components/ai-chat/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
<slot name="operateBefore">
<span></span>
</slot>

<el-button
v-if="isUserInput"
class="user-input-button mb-8"
Copy link
Copy Markdown
Contributor

@shaohuzhang1 shaohuzhang1 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code looks mostly clean. However, here's a suggestion for improvement:

- **Suggestion:** Consider adding `v-slot` with dynamic arguments instead of using `<slot>` directly if you expect multiple slots to be used in different places within the same component.

For example, if you have multiple custom slots that need distinct behaviors based on their names (e.g., `"header"`, `"content"`), you can use `v-slot:[name]`.

Example usage:
```html
<template>
  <div>
    <!-- Dynamic slot -->
    <component :is="'custom-slot-' + name"></component>

    <!-- Regular slots -->
    <slot></slot> <!-- Fallback/default slot -->

    <!-- Specific named slots -->
    <slot name="title">Default title</slot>
  </div>
</template>

<script setup>
import CustomSlotTitle from './CustomSlotTitle.vue'
import CustomSlotContent from './CustomSlotContent.vue'

defineProps({
  // props...
})

const componentName = () => {
  const { name } = getCurrentInstance().type;
  return name.startsWith('CustomSlot') ? name.replace(/^CustomSlot/i, '') : '';
};
</script>

This approach provides more flexibility and clarity about how your slots should behave across different templates. If you have a specific implementation in mind when dealing with custom slots, let me know!

Expand Down
6 changes: 3 additions & 3 deletions ui/src/locales/lang/en-US/views/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ export default {
referencesTooltip:
'By adjusting the content of the prompt, you can guide the direction of the large model chat. This prompt will be fixed at the beginning of the context. Variables used: {data} carries known information from the knowledge; {question} is the question posed by the user.',
defaultPrompt: `Known information: {data}
Question: {question}
Response requirements:
- Please use concise and professional language to answer the user's question.
Question: {question}
Response requirements:
- Please use concise and professional language to answer the user's question.
`
},
historyRecord: {
Copy link
Copy Markdown
Contributor

@shaohuzhang1 shaohuzhang1 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly clean and well-structured. Here are some minor observations:

  1. The indentation style could be consistent with other parts of the file.

  2. The variable names {data} and {question} are reused in both places within each object. If these variables should refer to different data sources, this should be clarified.

  3. There seems to be duplication between "by adjusting" or "- please use concise and professional language" and similar phrases elsewhere in the comments.

  4. Some line breaks could be adjusted for better readability.

Overall, the function seems to achieve its intended purpose effectively, but these are just points that might want further attention based on how it will be used and maintained long-term.

Expand Down