fix: ensure tool parameters are properly handled by reloading JSON

[shaohuzhang1]

fix: ensure tool parameters are properly handled by reloading JSON --bug=1053980 --user=刘瑞斌 【应用】MCP节点的工具参数引用参数时，对话过程中参数值发生变化，MCP节点没有获取最新的参数值 https://www.tapd.cn/57709429/s/1676830

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code is generally well-written and follows standard Python conventions, but there are a few improvements and suggestions to enhance clarity and performance:

1. Unnecessary JSON Conversion: The line params = json.loads(json.dumps(tool_params)) does not add significant value because it converts the input to a string and then back to an object. This can introduce additional processing time.

2. Variable Naming: Use descriptive variable names instead of single characters (s, session, etc.) to improve readability.

3. Function Parameter Order: Ensure that function parameters are ordered consistently within their definitions.

4. Asynchronous Function Usage: Since call_tool uses await, make sure all asynchronous operations (like json.loads) are awaited properly.

Here's a revised version of the code with these improvements:

@@ -18,7 +18,7 @@ def save_context(self, details, workflow_manage):
 
     async def execute(
         self,
         mcp_servers_json_str: str,
-        tool_params_dict: dict,
+        tool_params_json_str: str,
         **kwargs,
     ) -> NodeResult:
         try:
             # Load MCP server list from JSON string
             servers = json.loads(mcp_servers_json_str)

Additional Recommendations:

• Error Handling: Consider adding error handling around JSON parsing and other operations to manage unexpected inputs gracefully.
• Logging: Implement logging to track the execution flow and any errors encountered during operation.

These changes should help ensure better understanding and maintainability of the code.