Skip to content

fix: Embedding dialogue asker parameter does not take effect #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 2, 2025
Merged

fix: Embedding dialogue asker parameter does not take effect #2773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/application/serializers/application_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ def get_query_api_input(self, application, params):
for field in input_field_list:
if field['assignment_method'] == 'api_input' and field['variable'] in params:
query += f"&{field['variable']}={params[field['variable']]}"

if 'asker' in params:
query += f"&asker={params.get('asker')}"
return query

class AccessTokenSerializer(serializers.Serializer):
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet does not contain any obvious syntax errors or major issues. However, there is one potential optimization suggestion regarding string formatting methods:

Suggestion for Optimization:
Instead of using multiple += statements to build the query, consider using Python's built-in list comprehension within the join() function, which can simplify and potentially improve performance. Here’s how you could refactor this part of the code:

for field in input_field_list:
    if field['assignment_method'] == 'api_input' and field['variable'] in params:
        # Using join with list compression and f-strings can make it more concise and efficient
        query.append(f"{field['variable']}={params[field['variable']]}")
if 'asker' in params:
    query.append(f"asker={params.get('asker')}")

# Joining the list into a single string separated by '&'
return "&".join(query)

This approach will create a list of strings, then use &.join() to concatenate them efficiently. This method reduces the overhead associated with concatenation operations done by +=, especially when dealing with many fields.

Expand Down