Skip to content

fix: Dialogue embedding to modify name #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 2, 2025
Merged

fix: Dialogue embedding to modify name #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/src/views/chat/embed/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,8 @@ function editName(val: string, item: any) {
const obj = {
abstract: val
}

log.asyncPutChatClientLog(applicationDetail.value.id, item.id, obj, loading).then(() => {
const find = chatLogData.value.find((item: any) => item.id == item.id)
const find = chatLogData.value.find((row: any) => row.id === item.id)
if (find) {
find.abstract = val
}
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no obvious irregularities or significant issues with this code. Here are some minor suggestions for improvement:

  1. Variable Name Consistency: Ensure that all variable names are consistent throughout the scope of the method. The change from val to item.id should be applied consistently.

    function editName(newVal: string, itemId: number) {
  const obj = {
    abstract: newVal
  };
  
  // Use newValue instead of val and itemId instead of item.id
  log.asyncPutChatClientLog(applicationDetail.value.id, itemId, obj, loading).then(() => {
    const find = chatLogData.value.find((row: any) => row.id === itemId);
    if (find) {
      find.abstract = newVal;
    }
  });
}

  2. Type Declaration: It's recommended to provide type declarations for parameters and variables to improve readability and maintainability.

  3. Function Arguments: Consider renaming arguments to make them more descriptive of their purpose. For example, newVal can become updateAbstract.

Here’s the updated version with these improvements:

function editAbstract(updateAbstract: string, itemId: number) {
  const updateObj = {
    abstract: updateAbstract
  };

  log.asyncPutChatClientLog(applicationDetail.value.id, itemId, updateObj, loading).then(() => {
    const foundItem = chatLogData.value.find((row: any) => row.id === itemId);
    if (foundItem) {
      foundItem.abstract = updateAbstract;
    }
  });
}

These changes enhance the clarity and robustness of the function while maintaining its functionality.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/views/chat/mobile/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function editName(val: string, item: any) {
}

log.asyncPutChatClientLog(applicationDetail.value.id, item.id, obj, loading).then(() => {
const find = chatLogData.value.find((item: any) => item.id == item.id)
const find = chatLogData.value.find((row: any) => row.id === item.id)
if (find) {
find.abstract = val
}
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in your code: row should be used instead of item in the find condition. You have already specified that you want to use the id property from the chatLogData.value, so it's better to stick to using it. This will ensure the code works correctly and follows best practices. Here's the corrected line:

const find = chatLogData.value.find((it: any) => it.id === item.id);

By doing this you correct the misspelling of it, which matches the expected variable name (row).

Expand Down