Skip to content

fix: When answering a question - click to stop answering - wait until the question is approximately answered, then click to continue - it will remain in a stopped answering state #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 2, 2025
Merged

fix: When answering a question - click to stop answering - wait until the question is approximately answered, then click to continue - it will remain in a stopped answering state #2784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/src/api/type/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,10 @@ export class ChatRecordManage {
write() {
this.chat.is_stop = false
this.is_stop = false
this.is_close = false
if (!this.is_close) {
this.is_close = false
}

this.write_ed = false
this.chat.write_ed = false
if (this.loading) {
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code does not contain any significant irregularities or serious issues at the given line numbers and context you've specified. However, there is a redundant assignment (if (!this.is_close) { this.is_close = false; }) that can be removed to simplify it.

Here's the optimized version of the write method:

export class ChatRecordManage {
  // ... other methods ...

  write() {
    this.chat.is_stop = false;
    this.is_stop = false;
    if (!this.is_close) {
      this.is_close = false; // This line could be removed
    }
    this.write_ed = false;
    this.chat.write_ed = false;
    // ... rest of the method ...
  }

  // ... other methods ...
}

Optimization Suggestions:

  • Remove the redundant this.is_close = false; inside the condition because it assigns false twice, unnecessarily.

Expand Down