Skip to content

fix: After the page is redirected, the voice playback does not stop #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 3, 2025
Merged

fix: After the page is redirected, the voice playback does not stop #2789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ui/src/components/ai-chat/component/operation-button/ChatOperationButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,9 @@ onBeforeUnmount(() => {
if (audioManage.value) {
audioManage.value.pause()
}
if (window.speechSynthesis) {
window.speechSynthesis.cancel()
}
})
</script>
<style lang="scss" scoped>
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has several optimizations and improvements that can be made:

- The `onBeforeUnmount` hook is used to perform cleanup operations when the component is unmounted. Adding checks for `window.speechSynthesis` allows for graceful handling of speech synthesis when the application is closed.

- Ensure that any resources managed by the `AudioManage`, such as media streams or timers, are released within this function to prevent memory leaks. However, since you only see the `pause` method being called on it, no explicit cleanup might be necessary unless there are other related methods or properties that need attention.

Here is the improved version with comments:

```html
<script setup lang="ts">
import { ref } from 'vue'
import AudioManage from './components/AudioManage.vue' // Assuming AudioManage is a custom component

const audioManage = ref<AudioManage>()

onMounted(async () => {
  await new Promise(resolve => setTimeout(resolve, 500)) // Example asynchronous task
})

onBeforeUnmount(() => {
  if (audioManage.value && typeof audioManage.value.pause === 'function') {
    audioManage.value.pause()
  }

  window.speechSynthesis?.cancel() // Safely cancel speech synthesis regardless of availability
})
</script>

<style scoped lang="scss">
// Add styles scoped here...
</style>

Make sure to replace './components/AudioManage.vue' with the actual path to your component file and adjust the example asynchronous task as needed. Additionally, consider adding more robust error handling around any external APIs or components to improve user experience during runtime errors.

Expand Down