Skip to content

fix: During the debugging process, the browser voice will automatically play after returning to other pages #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 3, 2025
Merged

fix: During the debugging process, the browser voice will automatically play after returning to other pages #2794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/src/components/ai-chat/component/operation-button/ChatOperationButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,8 @@ onMounted(() => {
})
})
onBeforeUnmount(() => {
bus.off('change:answer')
bus.off('play:pause')
if (audioManage.value) {
audioManage.value.pause()
}
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet has a few minor adjustments and optimizations that can be made:

  1. Remove Duplicates: The import statement is duplicated at the top of the file and should only appear once.
  2. Unnecessary Comment: The comment on line 537 is unnecessary as it matches the previous line.

Here's the revised version with these improvements:

import { ref } from 'vue';
import bus from '@/utils/bus';

export default {
  setup() {
    const audioManage = ref(null);
    // Other code...

    onMounted(() => {
      bus.on('change:answer', handleChangeAnswer);
      bus.on('play:pause', handlePlayPause);

      // Other code...
    });

    function handleChangeAnswer(e) {
      // Handle change:answer event
    }

    function handlePlayPause(e) {
      // Handle play:pause event
    }

    onBeforeUnmount(() => {
      bus.off('change:answer');
      bus.off('play:pause');

      if (audioManage.value) {
        audioManage.value.pause();
      }
    });
  },
};

These changes ensure better organization and reduce redundancy in the code while maintaining its functionality.

Expand Down