fix: The local rearrangement model cannot be loaded

[shaohuzhang1]

fix: The local rearrangement model cannot be loaded

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The code has a minor issue with incorrect typing for model_kwargs. It needs to be ClassVar rather than Any, but since they are both used interchangeably here, it doesn't cause runtime errors if you choose Any.

Here's the corrected version of the code:

@@ -72,8 +72,8 @@
         tokenizer: Any = None
         model: Optional[str] = None
         cache_dir: Optional[str] = None
-        model_kwargs: ClassVar = {} # Incorrectly defined as 'ClassVar'
+        model_kwargs: Any = {} 

If you want to ensure strict type checking by specifying dict instead of using Any, change both occurrences to `Dict[str, Any]:

class LocalBaseReranker(BaseKBBaseModel, BaseDocumentCompressor):
    tokenizer: Any = None
    model: Optional[str] = None
    cache_dir: Optional[str] = None
    model_kwargs: Dict[str, Any] = {}  # Corrected to accept only strings as keys

    def __init__(self, model_name, cache_dir=None, **model_kwargs):
        super().__init__()

Suggested Optimization:

1. Use More Pythonic Defaults: Consider default parameters in the __init__ method where appropriate.
2. Ensure Type Hint Consistency: Always use specific types (e.g., dict vs any) and avoid unnecessary variance (*args, **kwargs) unless really needed.

These suggestions make your code more readable and consistent, which can help maintainability over time.