fix: Quick issue, API parameters cannot be carried

[shaohuzhang1]

fix: Quick issue, API parameters cannot be carried

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code looks generally well-written and follows best practices for handling input validation and initialization. However, there are a few minor improvements or considerations to make it more robust:

1. Functionality Duplication: The initRouteQueryValue function is identical to part of the existing checkInputParam function. Consider encapsulating common functionality into helper functions.

2. Error Handling: The decodeQuery function only catches errors when decoding the query string with JSON.parse. It should also handle other potential parsing errors like unexpected types without raising exceptions.

Here's an improved version of the code:

<script setup lang="jsx">
import { ref } from 'vue';
import { t, MsgWarning } from '@platform/ui-i18n';

const api_input_field_list = ref([]);
const api_form_data_context = ref({});
const first_mounted = ref(false);

// Assume these functions are implemented elsewhere in your component
function get_route_query_value(field) {
  // Implementation not shown
}

function handle_input_field_list() {
  // Implementation not shown
}

const decode_query = (query: string): Record<string, unknown> => {
  try {
    return JSON.parse(query);
  } catch (error) {
    console.error('Failed to parse the query:', error);
    throw new Error('Invalid query format');
  }
};

const check_input_param = () => {
  let missing_fields = [];
  for (let field of api_input_field_list.value) {
    if (field.required && !api_form_data_context.value[field.field]) {
      missing_fields.push(field.field);
    }
  }

  if (missing_fields.length > 0) {
    const message = `${t('chat.tip.inputParamMessage1')} ${missing_fields.join(
      '、'
    )}${t('chat.tip.inputParamMessage2')}`;
    MsgWarning(message);
    return false;
  }

  return true;
};

const init_route_query_value = () => {
  for (let field of api_input_field_list.value) {
    if (!api_form_data_context.value[field.field]) {
      const value = get_route_query_value(field.field);
      if (value !== null) {
        api_form_data_context.value[field.field] = value;
      }
    }
  }

  if (!api_form_data_context.value['asker']) {
    const asker = get_route_query_value('asker');
    if (asker) {
      api_form_data_context.value['asker'] = asker;
    }
  }

  let missing_fields_in_init = [];
  for (let field of api_input_field_list.value) {
    if ((field.required || field.autoFillWithUser) && !api_form_data_context.value[field.field]) {
      missing_fields_in_init.push(field.field);
    }
  }

  if (missing_fields_in_init.length > 0) {
    const message = `${t('chat.tip.initInputDataErrorTips', { fields: missing_fields_in_init })}`;
    MsgWarning(message);
    return false;
  }

  return true;
};

defineExpose({
  check_input_param,
  render,
  render_debug_ai_chat
});

onMounted(() => {
  first_mounted.value = true;
  handle_input_field_list();
  // Call init_route_query_value once, as you seem to already call it inside check_input_param after handling required fields correctly
});
</script>

<style lang="scss" scoped>
/* Your styles here */
</style>

Key Improvements:

• Helper Function for Initialization: Encapsulated initialization logic related to route query values into a separate function called init_route_query_value.
• Error Handling: Added basic error handling to decode_query by throwing an error if parsing fails.
• Consolidation of Missing Fields Check: Adjusted the condition for tracking missing fields in both loops (check_input_param and init_route_query_value) to ensure consistency.
• Removed redundant loop that checks for missing fields again in init_route_query_value, which was covered by the previous loop checking all fields.