Skip to content

fix: History record error in dialogue basic mode #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangdan-fit2cloud merged 1 commit into from
Apr 10, 2025
Merged

fix: History record error in dialogue basic mode #2844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ui/src/components/ai-chat/component/answer-content/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
class="content"
@mouseup="openControl"
:style="{
'padding-right': showAvatar ? 'var(--padding-left)' : '0'
'padding-right': showUserAvatar ? 'var(--padding-left)' : '0'
}"
>
<el-card shadow="always" class="mb-8 border-r-8" style="--el-card-padding: 6px 16px">
Expand Down Expand Up @@ -52,7 +52,7 @@
class="content"
:style="{
'padding-left': showAvatar ? 'var(--padding-left)' : '0',
'padding-right': showAvatar ? 'var(--padding-left)' : '0'
'padding-right': showUserAvatar ? 'var(--padding-left)' : '0'
}"
>
<OperationButton
Expand Down Expand Up @@ -92,7 +92,9 @@ const emit = defineEmits(['update:chatRecord'])
const showAvatar = computed(() => {
return user.isEnterprise() ? props.application.show_avatar : true
})

const showUserAvatar = computed(() => {
return user.isEnterprise() ? props.application.show_user_avatar : true
})
const chatMessage = (question: string, type: 'old' | 'new', other_params_data?: any) => {
if (type === 'old') {
add_answer_text_list(props.chatRecord.answer_text_list)
Copy link
Copy Markdown
Contributor

@shaohuzhang1 shaohuzhang1 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code looks generally clean and functional with minimal issues. However, there are a few points that could be optimized or improved:

  1. Consistent Naming: The names showAvatar and showUserAvatar in the computed properties are slightly different, which is redundant since both serve similar purposes but refer to different fields (show_avatar vs show_user_avatar). Consider renaming either of them to maintain consistency.

  2. Computed Property Duplication: The line for setting padding-right is duplicated between two computed properties (showAvatar 和 showUserAvatar). This can make the logic more complex and prone to errors. If these lines should behave identically, you might want to consolidate the computation into a single property.

  3. Code Style Consistency: Ensure consistent spacing around operators and brackets for better readability.

Here's an updated version based on these considerations:

const { user } = useRuntimeConfig().public;
const { props, emit, currentQuestionIndexRef, questionLength, addAnswerTextList, answerTypeMap } =
      useChat();
      
// Consolidating the padding calculation into a single computed property
const calculatedPaddingRight = computed(() =>
  user.isEnterprise() ? !props.show_user_avatar || !showUserAvatars.value : false /* Default value */
);

function updateChatItem(chatRecord) {
  setChatRecordData({ ...chatRecord });
}

let questionCount;

async function ask(question, input_type, type) {
  const questionObject = constructNewMessage(
    `${currentQuestionIndexRef.value > -1 ? 'Next: ' : ''}${formatString(question)}`
  );
  
  // Use the consolidated computed property for padding right
  const chatClass = "content" +
                    ":style=" +
                      `{ \
                        'padding-left': ${calculatedPaddingRight.value ? 'var(--padding-left)' : '0'}, \
                        'padding-right': ${calculatedPaddingRight.value ? 'var(--padding-left)' : '0'} \
                      }`;

  let chatMsg = "";

By making these adjustments, the code becomes clearer and potentially more efficient while maintaining its functionality.

Expand Down
1 change: 1 addition & 0 deletions ui/src/components/ai-chat/component/question-content/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ const { user } = useStore()
const showAvatar = computed(() => {
return user.isEnterprise() ? props.application.show_user_avatar : true
})

const document_list = computed(() => {
if (props.chatRecord?.upload_meta) {
return props.chatRecord.upload_meta?.document_list || []
Copy link
Copy Markdown
Contributor

@shaohuzhang1 shaohuzhang1 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet appears to be part of a Vue.js component, specifically within an index.vue file. Here are some observations and suggestions for improvement:

  1. Use of useStore(): Ensure that you have correctly imported and used the Vuex store. If it's not working as expected, there might be a pathing issue.

  2. Computed Property for showAvatar: The computed property is correct but could be simplified slightly. Since it uses only properties from already reactive state (props application.show_user_avatar), it can be directly returned without wrapping in an additional function call:

    const showAvatar = computed(() => {
  return (
    user.isEnterprise &&
    !!(typeof props.application.show_user_avatar === 'boolean' && props.application.show_user_avatar)
  );
});

    This avoids unnecessary computations.

  3. Document List Computed Property: The computed property document_list looks mostly fine. However, consider checking for errors like undefined or null before accessing chatRecord.upload_meta.document_list. You might want to handle this gracefully:

    const document_list = computed(() => {
  try {
    if (props.chatRecord?.upload_meta) {
      return ([
        ...Array.isArray(props.chatRecord.upload_meta.document_list) ? props.chatRecord.upload_meta.document_list : [],
      ]).map(item => ({
        // Assuming item is an object with necessary properties
        id: item.id,
        name: item.name,
        url: item.url,
      }));
    }
    return [];
  } catch (error) {
    console.error('Error retrieving document list:', error);
    return [];
  }
});

  4. Potential for Optimization:

    • Minification: Consider minifying your JavaScript files using tools like Terser to reduce file size.
    • Linting: Use linters like ESLint to enforce consistent style and identify potential bugs.
    • Asynchronous Operations: If dealing with network requests or asynchronous data fetching, optimize these operations by utilizing asynchronous programming techniques.

  5. Vue DevTools and Debugging: Utilize browser developer tools to debug and inspect the rendered output and state. This will help you quickly find issues and performance bottlenecks.

By addressing these points, the code should become more efficient, robust, and easier to maintain.

Expand Down
7 changes: 7 additions & 0 deletions ui/src/views/chat/base/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
:available="applicationAvailable"
:appId="applicationDetail?.id"
:record="recordList"
:chatId="currentChatId"
@refresh="refresh"
>
<template #operateBefore>
<div>
Expand Down Expand Up @@ -67,10 +69,15 @@ const applicationDetail = computed({
set: (v) => {}
})
const recordList = ref([])
const currentChatId = ref('')

function newChat() {
currentChatId.value = 'new'
recordList.value = []
}
function refresh(id: string) {
currentChatId.value = id
}
</script>
<style lang="scss">
.chat {
Copy link
Copy Markdown
Contributor

@shaohuzhang1 shaohuzhang1 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no obvious errors or major issues in the provided code snippet. However, here are a few suggestions for improvement:

  1. Type Annotations: Adding type annotations to recordList and currentChatId can improve readability and help catch type-related errors during development.
const recordList: Ref<Array<any>> = ref([]);
const currentChatId: Ref<string> = ref('');
  1. Documentation of Parameters: Adding comments to parameters of functions that receive them (newChat, refresh) can make it easier for others (or yourself at a later time) to understand their purpose.
function newChat(): void {
  // Reset chat state when starting a new conversation
  currentChatId.value = 'new';
  recordList.value = [];
}

/**
 * Updates the chat ID based on a given string.
 *
 * @param id The identifier of the new chat session.
 */
function refresh(id: string): void {
  this.currentChatId = id;
}
  1. Refactor Function Names: While not mandatory, using descriptive function names can make the code more understandable, especially if they perform complex operations like resetting chat state.
function initiateNewConversation(): void {
  newChat();
}

Overall, the code is already quite clean, but these changes can enhance its maintainability and clarity.

Expand Down