Skip to content

fix: Application dialogue settings do not display history page style …#2866

Merged
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/chat-base
Apr 14, 2025
Merged

fix: Application dialogue settings do not display history page style …#2866
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/chat-base

Conversation

@wangdan-fit2cloud
Copy link
Copy Markdown
Contributor

…issue

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 14, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

}
.chat-width {
// max-width: 80%;
margin: 0 auto;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code contains an unnecessary <div class="chat__footer"> element at the end of the template that has no closing tag.

To address this issue:

  1. Remove the </div> after .chat-width.

  2. Ensure all HTML elements have properly nested and closed tags to avoid rendering errors or visual problems in browsers.

@wangdan-fit2cloud wangdan-fit2cloud merged commit c781c11 into main Apr 14, 2025
4 checks passed
@wangdan-fit2cloud wangdan-fit2cloud deleted the pr@main/chat-base branch April 14, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants