Skip to content

build: ui build error #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 24, 2025
Merged

build: ui build error #2975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common/management/commands/services/services/local_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def cmd(self):
'-b', bind,
'-k', 'gthread',
'--threads', '200',
'-w', worker,
'-w', str(worker),
'--max-requests', '10240',
'--max-requests-jitter', '2048',
'--access-logformat', log_format,
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is generally correct. However, there's an unnecessary conversion from worker to a string when passing it as an argument with '--workers'. This doesn't make sense because the -w flag expects an integer value.

Here is the corrected version of the command:

@@ -30,7 +30,7 @@ def cmd(self):
             '-b', bind,
             '-k', 'gthread',
             '--threads', '200',
-            '-w', worker,
+            '-w', worker,
             '--max-requests', '10240',
             '--max-requests-jitter', '2048',
             '--access-logformat', log_format,

Remove the str(worker) part after -w, since worker is already an integer and should be used directly without converting it.

Expand Down
1 change: 0 additions & 1 deletion ui/src/components/ai-chat/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ import UserForm from '@/components/ai-chat/component/user-form/index.vue'
import Control from '@/components/ai-chat/component/control/index.vue'
import { t } from '@/locales'
import bus from '@/bus'
import { fa } from 'element-plus/es/locale'
const transcribing = ref<boolean>(false)
defineOptions({ name: 'AiChat' })
const route = useRoute()
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The import statement import { fa } from 'element-plus/es/locale'; is not currently being used anywhere in the file and can be removed.

  2. Ensure that all necessary imports are correctly formatted and imported at the top of the file.

  3. Use meaningful naming conventions throughout the codebase to improve readability and maintainability.

  4. Consider refactoring complex logic or repeating sections into reusable components/functions for better organization and scalability.

  5. Check if there are any unnecessary dependencies included in your project and eliminate them where possible to reduce bundle size and increase load times.

  6. Review error handling within functions and ensure they cover all edge cases and potential errors gracefully.

  7. Ensure consistency in coding style across the entire application, such as consistent indentation, spacing, etc.

These points address common issues that may arise during code evaluation and suggest improvements to enhance its quality and efficiency.

Expand Down