Skip to content

fix: During the conversation, there is sensitive data in the application profile obtained by the application #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 29, 2025
Merged

fix: During the conversation, there is sensitive data in the application profile obtained by the application #3018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/application/serializers/application_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,8 @@ def profile(self, with_valid=True):
'stt_autosend': application.stt_autosend,
'file_upload_enable': application.file_upload_enable,
'file_upload_setting': application.file_upload_setting,
'work_flow': application.work_flow,
'work_flow': {'nodes': [node for node in application.work_flow.get('nodes') if
node.get('id') == 'base-node']},
'show_source': application_access_token.show_source,
'language': application_access_token.language,
**application_setting_dict})
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change in this function is removing all but one workflow node from application.work_flow.nodes before serializing it to JSON. This could potentially cause issues if the application relies on other nodes defined in the original workflow.

Potential improvements:

  1. Remove unnecessary code: The line if 'base-node' in [node.get('id') for node in ...]: can be simplified or removed entirely since you're already checking against a specific ID later.
  2. Consider adding error handling: It might be good to add a try-except block around operations involving parsing or accessing data within the workflow structure.

Expand Down