Skip to content

feat: Support Alibaba Bailian supplier qwen3 model #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 29, 2025
Merged

feat: Support Alibaba Bailian supplier qwen3 model #3020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/setting/models_provider/impl/aliyun_bai_lian_model_provider/credential/llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ def is_valid(self, model_type: str, model_name, model_credential: Dict[str, obje
return False
try:
model = provider.get_model(model_type, model_name, model_credential, **model_params)
model.invoke([HumanMessage(content=gettext('Hello'))])
if model_params.get('stream'):
for res in model.stream([HumanMessage(content=gettext('Hello'))]):
pass
else:
model.invoke([HumanMessage(content=gettext('Hello'))])
except Exception as e:
traceback.print_exc()
if isinstance(e, AppApiException):
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code provided has a few minor improvements that can be made:

  1. Handling Stream Mode: The model.stream method is only being called when model_params.get('stream') is truthy.
  2. Explicitly Handling None Types: If res in the stream mode returns None, it will not throw an exception but simply go to the next iteration of the loop.

Here's the updated code with these improvements included:

@@ -47,7 +47,12 @@
                 return False

         try:
             model = provider.get_model(model_type, model_name, model_credential, **model_params)
-            model.invoke([HumanMessage(content=gettext('Hello'))])
+            if 'stream' in model_params and model_params['stream']:
+                for res in model.stream([HumanMessage(content=gettext('Hello'))]):
+                    # Handle streaming output here, e.g., print(res)
+                    pass
+            else:
+                model.invoke([HumanMessage(content=gettext('Hello'))])

         except Exception as e:
             traceback.print_exc()
             if isinstance(e, AppApiException):

Additionally, consider adding error handling around any operations within the stream loop or where res might be None.

Expand Down