Skip to content

fix: The simple application demonstration cannot be opened #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Apr 29, 2025
Merged

fix: The simple application demonstration cannot be opened #3028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/serializers/application_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ def profile(self, with_valid=True):
'stt_autosend': application.stt_autosend,
'file_upload_enable': application.file_upload_enable,
'file_upload_setting': application.file_upload_setting,
'work_flow': {'nodes': [node for node in application.work_flow.get('nodes') if
'work_flow': {'nodes': [node for node in ((application.work_flow or {}).get('nodes', []) or []) if
node.get('id') == 'base-node']},
'show_source': application_access_token.show_source,
'language': application_access_token.language,
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are no major irregularities or issues found in the code. However, it's worth noting that accessing application.work_flow twice is redundant when using the ternary operator to handle potential None value scenarios. Here's a simplified version:

self.config = {
    "stt_autosend": application.stt_autosend,
    "file_upload_enable": application.file_upload_enable,
    "file_upload_setting": application.file_upload_setting,
    "work_flow": {  # Handle case where work_flow might not exist or be empty
        "nodes": [
            node for node in (application.work_flow.get("nodes", [])
                             if isinstance(application.work_flow, dict)
                             and 'nodes' in application_work_flow)
                              if node.get('id') == 'base-node']
    },
    "show_source": application_access_token.show_source,
    "language": application_access_token.language
}

This approach ensures that you only access the dictionary once and includes checks to ensure that both application.work_flow and its nodes key exist before processing them.

Expand Down