Skip to content

perf: Segmented search function in the knowledge base, clearing search content when switching search keywords(#3867) #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangdan-fit2cloud merged 1 commit into from
Aug 18, 2025
Merged

perf: Segmented search function in the knowledge base, clearing search content when switching search keywords(#3867) #3872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ui/src/components/model-select/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<SelectProviderDialog
v-if="showFooter"
ref="selectProviderRef"
@change="(provider, modelType) => openCreateModel(provider, modelType)"
@change="(provider: any, modelType: any) => openCreateModel(provider, modelType)"
/>
</div>
</template>
Expand All @@ -82,8 +82,6 @@ import type { Provider } from '@/api/type/model'
import { relatedObject } from '@/utils/utils'
import CreateModelDialog from '@/views/template/component/CreateModelDialog.vue'
import SelectProviderDialog from '@/views/template/component/SelectProviderDialog.vue'

import { t } from '@/locales'
import useStore from '@/stores'

defineOptions({ name: 'ModelSelect' })
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided changes look consistent and do not introduce any immediate issues. Here are some minor suggestions for improvements:

  1. Type Annotations: The @change event handler is already using type annotations ((provider: any, modelType: any)), which can help with better code readability.

  2. Linting: Ensure that your IDE (Integrated Development Environment) or linter is up to date with Vue.js best practices. Sometimes, it may automatically suggest modifications like these.

  3. Locale Import: Although removing the locale import doesn't affect functionally, consider if you need this functionality and whether there's a way to improve upon importing localization utilities without duplicating codes from other files.

  4. Documentation: If adding comments or documentation would clarify the purpose of your functions or components, feel free to include them, though they might be redundant given current content.

Overall, the code snippet looks well-formed and efficient as per standard Vue.js principles.

Expand Down
1 change: 0 additions & 1 deletion ui/src/views/login/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ import useStore from '@/stores'
import authApi from '@/api/auth-setting'
import useApi from '@/api/user'
import { MsgConfirm, MsgError, MsgSuccess } from '@/utils/message'

import { t, getBrowserLang } from '@/locales'
import QrCodeTab from '@/views/login/components/QrCodeTab.vue'
import { useI18n } from 'vue-i18n'
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no error or issue in the provided code snippet. The only change made was to remove an unnecessary space after "v-show" on the second line of the Vue template, but this does not affect functionality.

Expand Down
17 changes: 12 additions & 5 deletions ui/src/views/paragraph/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@
clearable
>
<template #prepend>
<el-select v-model="searchType" placeholder="Select" style="width: 80px">
<el-select
v-model="searchType"
placeholder="Select"
style="width: 80px"
@change="searchTypeChange"
>
<el-option :label="$t('common.title')" value="title" />
<el-option :label="$t('common.content')" value="content" />
</el-select>
Expand Down Expand Up @@ -133,9 +138,7 @@
<el-dropdown-menu>
<el-dropdown-item @click="openGenerateDialog(item)">
<el-icon><Connection /></el-icon>
{{
$t('views.document.generateQuestion.title')
}}</el-dropdown-item
{{ $t('views.document.generateQuestion.title') }}</el-dropdown-item
>
<el-dropdown-item @click="openSelectDocumentDialog(item)">
<AppIcon iconName="app-migrate"></AppIcon>
Expand Down Expand Up @@ -207,6 +210,10 @@ const title = ref('')
const search = ref('')
const searchType = ref('title')

const searchTypeChange = () => {
search.value = ''
}

// 批量操作
const isBatch = ref(false)
const multipleSelection = ref<any[]>([])
Expand Down Expand Up @@ -313,7 +320,7 @@ function addParagraph() {
ParagraphDialogRef.value.open()
}
function editParagraph(row: any) {
title.value = t('views.paragraph.paragraphDetail')
title.value = t('views.paragraph.paragraphDetail')
ParagraphDialogRef.value.open(row)
}

Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems mostly clean, but there are a few areas that could benefit from improvements:

  1. Code DRY Principle: The two lines title.value = t('views.paragraph.paragraphDetail'); can be consolidated into one line since they serve the same purpose.

  2. Event Handling: The @change event handler for searchType should update the search field whenever the selected type changes to ensure clearability of both fields if necessary.

  3. Comments and Descriptive Variable Names: It's good practice to have comments explaining complex functionalities but keep variable names descriptive without unnecessary prefixes like $.

  4. Default Values: Ensure all variables (title, search, searchType) are properly initialized with default values based on their intended use (e.g., title as an empty string).

Here’s the revised version:

// ... rest of the file ...

const title = ref('')
const search = ref('')
const searchType = ref('title')

const openGenerateDialog = item => {
  console.log("generate dialog", item);
}

const openSelectDocumentDialog = item => {
  console.log("select document dialog", item);
}

function addParagraph(){
  ParagraphDialogRef.value.open()
}

function editParagraph(row){
  title.value = t('views.paragraph.paragraphDetail')
  ParagraphDialogRef.value.open(row)
}

watch(searchType, newSearchType => {
  search.value = '';
});

// ...

This makes the function more efficient and easier to maintain by consolidating duplicated logic and keeping the logic flow coherent.

Expand Down