Skip to content

fix: Internationalization Error #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Aug 20, 2025
Merged

fix: Internationalization Error #3899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/locales/lang/en-US/ai-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default {
sizeLimit: 'Each file must not exceed',
imageMessage: 'Please process the image content',
documentMessage: 'Please understand the content of the document',
audioMessage: 'Please understand the video content',
audioMessage: 'Please understand the aideo content',
otherMessage: 'Please understand the file content',
errorMessage: 'Upload Failed'
},
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is mostly correct but there's a minor typo in the comment for audioMessage. It should read "Please understand the video content" instead of "video content", which it currently does.

Here’s the corrected version:

sizeLimit: 'Each file must not exceed',
imageMessage: 'Please process the image content',
documentMessage: 'Please understand the content of the document',
audioMessage: 'Please understand the video content', // Corrected typos here
otherMessage: 'Please understand the file content',
errorMessage: 'Upload Failed'
};

No further optimizations are necessary at this time based on the given information.

Expand Down
2 changes: 1 addition & 1 deletion ui/src/locales/lang/zh-CN/ai-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default {
sizeLimit: '单个文件大小不能超过',
imageMessage: '请解析图片内容',
documentMessage: '请理解文档内容',
audioMessage: '请理解视频内容',
audioMessage: '请理解音频内容',
otherMessage: '请理解文件内容',
errorMessage: '上传失败'
},
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code snippet appears to be correctly formatted and there are no known issues at the time of this generation (August 2025). If you need further assistance or optimizations, please let me know!

Expand Down
2 changes: 1 addition & 1 deletion ui/src/locales/lang/zh-Hant/ai-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default {
sizeLimit: '單個文件大小不能超過',
imageMessage: '請解析圖片內容',
documentMessage: '請理解檔案內容',
audioMessage: '請理解視頻內容',
audioMessage: '請理解音訊內容',
otherMessage: '請理解檔案內容',
errorMessage: '上傳失敗'
},
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly correct, but there are a couple of things to consider:

  1. String Translation: The audio key should indeed be audioMessage. Minor error correction here.

  2. Optimization: Ensure that the keys used as message identifiers (like sizeLimit, imageMessage) do not change frequently during deployment or internationalization updates. Consistent naming can help maintain readability.

  3. Comments: Adding comments might clarify what each line does if it's part of more complex logic elsewhere in your application.

Overall, the code is functional and clear with these minor adjustments.

Expand Down
Loading