Skip to content

fix: Workflow publishing name time error #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 3, 2025
Merged

fix: Workflow publishing name time error #3988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/serializers/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ def publish(self, instance, with_valid=True):
application.is_publish = True
application.save()
work_flow_version = ApplicationVersion(work_flow=application.work_flow, application=application,
name=timezone.now().strftime('%Y-%m-%d %H:%M:%S'),
name=timezone.localtime(timezone.now()).strftime('%Y-%m-%d %H:%M:%S'),
publish_user_id=user_id,
publish_user_name=user.username,
workspace_id=workspace_id)
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish method currently saves the current time in UTC using timezone.now(). This means that if you're working in a system where daylight saving time (DST) is applicable, your save time will be different from local time.

To avoid this discrepancy, use timezone.localtime(timezone.now()) to ensure the save time matches the user's location. Here’s how you can update your code:

def publish(self, instance, with_valid=True):
    application.is_publish = True
    application.save()

    # Use timezone localtime instead of utcnow for correct saved date and time
    work_flow_version = ApplicationVersion(
        work_flow=application.work_flow,
        application=application,
        name=datetime.strftime(application.created_at.astimezone(datetime.now().astimezone(tzinfo=None)), '%Y-%m-%d %H:%M:%S'), 
        publish_user_id=user_id,
        publish_user_name=user.username,
        workspace_id=workspace_id
    )

This change uses the created_at field on ApplicationInstance to get the timestamp which aligns better with what you might want to use when publishing something related to an instance creation date or event datetime, rather than always referring to now which could skew based on DST boundaries.

Expand Down
Loading