Skip to content

fix: Workflow session variables cannot be added #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 5, 2025
Merged

fix: Workflow session variables cannot be added #3998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ui/src/workflow/nodes/base-node/component/ChatFieldTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,11 @@ function refreshFieldList(data: any, index: any) {
return
}
}
if (index !== undefined) {
inputFieldList.value.splice(index, 1, data)
} else {
if ([undefined, null].includes(index)) {
inputFieldList.value.push(data)
} else {
inputFieldList.value.splice(index, 1, data)
}

ChatFieldDialogRef.value.close()
props.nodeModel.graphModel.eventCenter.emit('chatFieldList')
}
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is mostly correct but there's one potential issue to address. If data is an empty object {} or some other falsy value, it will cause the inputFieldList.value.splice() method to be called with incorrect arguments resulting in unexpected behavior.

To fix this, we can add a check for the truthiness of data before performing the splice operation:

@@ -84,6 +84,7 @@ function refreshFieldList(data: any, index: any) {
     return
 }

-  if ([undefined, null].includes(index)) {
+  if ([undefined, null].includes(index) || !Reflect.hasOwnProperty.call(data, 'id')) { // additional check for non-empty data

This check ensures that only properly formatted objects are spliced into the array to prevent errors. Here is the updated line:

   if ([undefined, null].includes(index) || !Reflect.hasOwnProperty.call(data, 'id')) {
     inputFieldList.value.push(data);
+  } else {
+    const idProperty = Reflect.ownKeys(data).find(key => key === 'id');
     inputFieldList.value.splice(idProperty ? index : inputFieldList.value.length, 1, data);
   }

Make this change based on your actual requirements, typically checking a unique identifier like id. The above check will ensure that an appropriate ID exists in the data object before attempting to edit it.

Expand Down
Loading