Skip to content

fix: Information regarding role permissions management has not been internationalised.#4000

Merged
zhanweizhang7 merged 1 commit intov2from
pr@v2@fix_not_internationalised
Sep 8, 2025
Merged

fix: Information regarding role permissions management has not been internationalised.#4000
zhanweizhang7 merged 1 commit intov2from
pr@v2@fix_not_internationalised

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: Information regarding role permissions management has not been internationalised. --bug=1061417 --user=张展玮 【国际化BUG】2.10版本,角色权限管理的信息没有国际化 https://www.tapd.cn/62980211/s/1768834

…nternationalised.

--bug=1061417 --user=张展玮 【国际化BUG】2.10版本,角色权限管理的信息没有国际化 https://www.tapd.cn/62980211/s/1768834
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Sep 8, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from django.utils.translation import gettext_lazy as _

from maxkb import settings

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet appears to be updating django.utils.translation.gettext with its lazy equivalent gettext_lazy. This can improve performance by not performing immediate translation when the string is referenced but instead delaying it until actually rendered. There's no apparent other issues or optimizations needed based on this update.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhanweizhang7 zhanweizhang7 merged commit 76766eb into v2 Sep 8, 2025
3 of 6 checks passed
@zhanweizhang7 zhanweizhang7 deleted the pr@v2@fix_not_internationalised branch September 8, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants