Skip to content

fix: Information regarding role permissions management has not been internationalised. #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Sep 8, 2025
Merged

fix: Information regarding role permissions management has not been internationalised. #4000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common/constants/permission_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from typing import List

from django.db import models
from django.utils.translation import gettext as _
from django.utils.translation import gettext_lazy as _

from maxkb import settings

Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet appears to be updating django.utils.translation.gettext with its lazy equivalent gettext_lazy. This can improve performance by not performing immediate translation when the string is referenced but instead delaying it until actually rendered. There's no apparent other issues or optimizations needed based on this update.

Expand Down
Loading