Skip to content

fix: Workflow start time and time zone error #4011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 9, 2025
Merged

fix: Workflow start time and time zone error #4011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/start_node/impl/base_start_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_global_variable(node):
history_context = [{'question': chat_record.problem_text, 'answer': chat_record.answer_text} for chat_record in
history_chat_record]
chat_id = node.flow_params_serializer.data.get('chat_id')
return {'time': timezone.now().strftime('%Y-%m-%d %H:%M:%S'), 'start_time': time.time(),
return {'time': timezone.localtime(timezone.now()).strftime('%Y-%m-%d %H:%M:%S'), 'start_time': time.time(),
'history_context': history_context, 'chat_id': str(chat_id), **node.workflow_manage.form_data,
'chat_user_id': body.get('chat_user_id'),
'chat_user_type': body.get('chat_user_type'),
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet contains a couple of improvements that I would suggest:

  1. Use datetime instead of time: The original code uses timezone.now() followed by .strftime(), which returns an ISO-formatted string. However, it's typically better to use datetime.datetime.now() with appropriate timezone handling if needed.

  2. Add type hints for arguments and variables: This can help clarify the expected types, making the function more maintainable and robust.

Here's the revised version:

import datetime
from django.utils import timezone

def get_global_variable(node) -> dict:
    # Assuming history_chat_record is defined elsewhere
    history_context = [
        {
            "question": chat_record.problem_text,
            "answer": chat_record.answer_text
        }
        for chat_record in history_chat_record
    ]
    
    chat_id = node.flow_params_serializer.data.get('chat_id')
    
    current_datetime = timezone.localtime(timezone.now())
    
    start_time = time.time()
    
    return {
        'time': current_datetime.strftime('%Y-%m-%d %H:%M:%S'),
        'start_time': start_time,
        'history_context': history_context,
        'chat_id': str(chat_id),
        **node.workflow_manage.form_data,
        'chat_user_id': body.get('chat_user_id'),
        'chat_user_type': body.get('chat_user_type'),
    }

These changes should make the code cleaner and potentially faster due to avoiding explicit conversion from one format to another unnecessarily.

Expand Down
Loading