fix: Drift of the loop body during each refresh in the canvas#4116
fix: Drift of the loop body during each refresh in the canvas#4116shaohuzhang1 merged 1 commit intov2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| y = props.nodeModel.properties.node_data.loop.y | ||
| } | ||
| const nodeModel = props.nodeModel.graphModel.addNode({ | ||
| type: loopBodyNode.type, |
There was a problem hiding this comment.
The provided code has a few minor improvements that can be made:
-
Consistent Variable Declarations: The variable
typeshould match the property name in the object being passed tographModel.addNode(). In this case, it is defined asloopBodyNode.type, but later used withtype. -
Redundant Assignment: The line
y = props.nodeModel.properties.node_data.loop.y - 330;will always result in the same value becauseyis not reassigned anywhere else within the function.
Here's the revised version:
const mountLoopBodyNode = () => {
if (props.nodeModel.properties.node_data.loop) {
const { x, y } = props.nodeModel.properties.node_data.loop;
} else {
// Handle the case when loop data is missing
x = undefined;
y = undefined;
}
const nodeType = loopBodyNode.type;
const nodeModel = props.nodeModel.graphModel.addNode({
type: nodeType,
x,
y,
});
};Additionally, you might want to consider adding comments or error handling for cases where loopData might be null or undefined.
1 participant
fix: Drift of the loop body during each refresh in the canvas