fix: Get workspace_id from workflow params

[shaohuzhang1]

fix: Get workspace_id from workflow params

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code appears to be part of a method that saves data related to documents and paragraphs. Here's my review:

1. Variable Renaming: The workspace_id variable has been renamed from "default" to self.workflow_params.get("workspace_id"). This is appropriate if the default value might change or depend on workflow parameters.

2. List Initialization: The initialization of both document_model_list and paragraph_model_list at the beginning seems unnecessary based on the context. They should only be initialized within the loop where they are used.

3. Code Structure: While the function structure remains consistent, it could benefit slightly from more structured comments explaining each step of the process.

Overall, the code performs its intended task without major issues, but there’s an opportunity to optimize list initializations based on the control flow logic.

Optimized Code:

def save(self, document_list):
    # Assuming serializer.data contains valid document data
    document_list = serializer.data
    
    knowledge_id = self.workflow_params.get("knowledge_id")
    workspace_id = self.workflow_params.get("workspace_id", "default")
    
    document_models = []
    paragraph_models = []
   
    for doc_data in document_list:
        document_model = Document.objects.create(
            knowledge=knowledge_id,
            title=doc_data['title'],
            content=doc_data['content']
        )
        document_models.append(document_model)
        
        for para_data in doc_data['paragraphs']:
            paragraph_model = Paragraph.objects.create(
                document=document_model,
                text=para_data['text']
            )
            paragraph_models.append(paragraph_model)

    return {"documents": document_models, "paragraphs": paragraph_models}

In this revised version:

• The lists documentModels and paragraphModels are initialized outside the loops.
• Each iteration over document_list creates a Document object, adding it to document_models.
• For each document, a corresponding list comprehension populates associated Paragraph objects into paragraph_models.

This approach improves readability by clearly separating responsibilities, reducing redundant operations, and potentially improving performance by minimizing database queries during multiple iterations.