fix: Workflow Execution details can be filtered using status filtering#4441
fix: Workflow Execution details can be filtered using status filtering#4441shaohuzhang1 merged 1 commit intov2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| 'meta': a.meta, 'run_time': a.run_time, 'create_time': a.create_time}) | ||
|
|
||
| def action(self, instance: Dict, user, with_valid=True): | ||
| if with_valid: |
There was a problem hiding this comment.
The provided code has a few issues:
- The
get_query_setmethod returns results without including thecreate_time. - In the
listandpagemethods, dictionary keys should be camelCase rather than snake_case (e.g.,'id', not'ID'). This follows Python naming conventions. - The
actionmethod's parameter namewith_validis confusing since it doesn't indicate whether validation is actually taking place within the function. It might help to rename this or clarify its purpose.
Here are some optimization suggestions:
- Consider adding default values for optional fields in the serializer definitions where appropriate, such as setting
allow_blank=Trueanddefault=None.
Overall, the code is well-structured but could benefit from these corrections for better readability and compatibility with common coding standards.
1 participant
fix: Workflow Execution details can be filtered using status filtering