fix: When there are user input parameters in the workflow, the data source setting information is cleared after returning to the previous step from the user input page#4442
Conversation
…ource setting information is cleared after returning to the previous step from the user input page
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| <keep-alive :key="key" :include="['DataSource', 'KnowledgeBase']"> | ||
| <component | ||
| ref="ActionRef" | ||
| :is="ak[active]" |
There was a problem hiding this comment.
In your code, there are two potential issues that need to be addressed:
-
Variable Name Consistency: The variable
keyis used with a capital letter (@Keyin the template) but it should be consistently used as lower case (keyin:key="key"). This consistency can help avoid syntax errors and improve legibility. -
Component Case Sensitivity: The component names
'DataSource','KnowledgeBase', and their references inak[active]have inconsistent casing which might cause runtime issues depending on your environment’s case sensitivity settings.
To optimize the code:
- Ensure you keep all instance variables consistent (e.g., using lowercase for key).
- Maintain consistent naming conventions throughout the codebase.
Here's the corrected version of your code snippet:
<template>
<el-container class="full-height">
<el-header height="48px" @click.native.prevent.stop="">
<!-- Header content -->
</el-header>
<el-main :style="{ maxHeight: 'calc(100vh - 96px)', overflow: 'auto' }">
<keep-alive :key="key" :include="['dataSource', 'knowledge_base']">
<component
ref="actionRef"
:is="ak[active]"
:close-on-press-escape="false"
/>
</keep-alive>
</el-main>
<el-footer>Footer</el-footer>
</el-container>
</template>
<script>
export default {
data() {
return {
isLoading: false,
key: Math.random().toString(),
ak: {},
active: ''
};
},
methods: {
// Method definitions
}
};
</script>Make sure to adjust this example to fit within your project structure and integrate the rest of your logic accordingly.
fix: When there are user input parameters in the workflow, the data source setting information is cleared after returning to the previous step from the user input page