fix: Application List - Open in More Actions to go to the chat, page returns 404

[shaohuzhang1]

fix: Application List - Open in More Actions to go to the chat, page returns 404

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

After reviewing the provided code snippet, there are a few key points to consider:

1. Missing URL Encoding: The res.data.access_token is appended directly to the base URL without encoding it. This can lead to issues if the token contains special characters that require proper escaping.

2. Excessive Type Casting: Although not necessarily an issue, using any types (row: any, aips: any) throughout might limit type safety and make debugging more difficult. Consider replacing them with specific types as appropriate.

3. Unused Variables/Methods: There's no need to use apiParams before checking its existence because you already return the modified base URL regardless of whether it exists.

4. Optimization: While the current implementation might work well for simple cases, ensure that handling multiple API calls or larger data structures doesn't degrade performance.

Here's an optimized version of the function with some suggested improvements:

function toChat(row) {
  let aips = row.aips || [];
  
  // Encode the access token to handle special characters safely
  const accessToken = encodeURIComponent(res?.data?.access_token);
  const apiParams = Object.keys(mapToUrlParams(aips))
                         .map(key => `${key}=${encodeURIComponent(mapToUrlParams(aips)[key])}`)
                         .join('&');
  
  const baseURL = application.location;
  const fullUrl = `${baseURL}${accessToken}${apiParams}`;
  
  window.open(fullUrl);
}

Explanation:

• Encoded the accessToken using encodeURIComponent.
• Used Object.keys() to get all keys from mapToUrlParams(aips) for better control over which parameters are included.
• Joined encoded parameter strings with their names separated by &.

This approach ensures that any special characters in the access token and other URL components are handled properly, maintaining data integrity.