Skip to content

fix: The nodes that can be added in the loop body are missing, and there are multiple recall nodes added#4450

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_workflow
Dec 5, 2025
Merged

fix: The nodes that can be added in the loop body are missing, and there are multiple recall nodes added#4450
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_workflow

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: The nodes that can be added in the loop body are missing, and there are multiple recall nodes added

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Dec 5, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 12a3e9b into v2 Dec 5, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_workflow branch December 5, 2025 10:23
list: [documentSplitNode, knowledgeWriteNode, documentExtractNode],
},
{
label: t('workflow.nodes.classify.businessLogic'),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s a review of the code snippet you provided, with some potential issues addressed:

  1. Duplicate list in "Views" Menu:

    {
      label: t('views.knowledge.title'),
      // List is defined twice here: one above (documentSplitNode) and below (knowledgeWriteNode)
    }

    This can be simplified to avoid redundancy.

  2. Missing Translation Keys:
    The code includes placeholders like t('views.tool.dataSource.title'), but these translations seem incomplete (...). It's important to ensure that all translation keys correspond to actual strings in your locale files.

  3. Suggested Optimization: Reduce duplication by consolidating lists if they share common elements.

export const applicationLoopMenuNodes = [
  { label: t('views.applications.title'), list: [appListNode] }
]

export const knowledgeLoopMenuNodes = [
  {
    label: t('views.tool.dataSource.title'),
    list: [dataSourceLocalNode, dataSourceWebNode]
  },
  {
    label: t('workflow.nodes.classify.aiCapability'),
    list: [aiCapabilityListNode]
  },
  {
    label: t('workflow.nodes.classify.businessLogic'),
    list: [logicFlowListNode]
  },
  {
    label: t('workflow.nodes.classify.dataPreprocessing'),
    list: [dataPreprocessListNode]
  },
  {
    label: t('views.knowledge.title'),
    list: [docSplitNode, knowledgeWriteNode, docExtractNode]
  }
]

This restructuring reduces repetition and improves readability.

  1. Ensure All Nodes Have Corresponding Translations:
    Make sure every key used in the t().

Feel free to adjust or expand upon these findings based on additional context or requirements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant