Skip to content

fix: Application List - Hold down Ctrl+to set the new window opened to still be the application list page #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 5, 2025
Merged

fix: Application List - Hold down Ctrl+to set the new window opened to still be the application list page #4451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/src/views/application/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,10 @@ function settingApplication(event: any, row: any) {
if (event?.ctrlKey) {
event?.preventDefault()
event.stopPropagation()
window.open(`/application/workspace/${row.id}/workflow`, '_blank')
const newUrl = router.resolve({
path: `/application/workspace/${row.id}/workflow`,
}).href
window.open(newUrl)
} else {
router.push({ path: `/application/workspace/${row.id}/workflow` })
}

@shaohuzhang1 shaohuzhang1 Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The given code seems to be properly structured and free from syntax errors. However, there are few optimizations that can be considered:

  1. Functionality Simplification: Since row is passed as an argument to the function, you don't need to check if event.ctrlKey exists before accessing it. This can reduce verbosity:

    const { ctrlKey } = event || {};

  2. Avoiding Duplicated Code: The window.open calls in both branches of the conditional statement could share some logic. You might want to refactor them into separate utility functions or a helper method.

  3. Use of Router Functions Directly: Instead of calling router.resolve, you could directly call router.replace or replaceSync depending on whether it needs to trigger a history navigation or not. For opening a new tab without navigating through history:

    window.open(router.resolve({ path: `/application/workspace/${row.id}/workflow` }).href, '_blank');

  4. Type Checking/Validation: Ensure that event and row.id have been defined when this function is called. Proper type checking and validation would prevent runtime errors if either parameter were missing.

Overall, the provided code performs well and should work as expected, but these refinements can make it more robust and concise. Make those changes based on your application's requirements.

Expand Down
Loading