fix: After renaming the predecessor node, the variable list was not updated#4452
fix: After renaming the predecessor node, the variable list was not updated#4452shaohuzhang1 merged 1 commit intov2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| props.nodeModel.clear_next_node_field(true) | ||
| nodeNameDialogVisible.value = false | ||
| formEl.resetFields() | ||
| } else { |
There was a problem hiding this comment.
No significant irregularities, issues, or optimizations were found in the provided code snippet. It updates an object property if it exists within an array of child nodes, sets a dialog visibility flag to false, resets field values from a form instance, and optionally clears fields on the next node after updating.
The changes include setting properties directly on props.nodeModel.properties with bracket notation for more flexibility and clearing next-node fields using ?.clear_next_node_field(true). This makes the code concise and easy to understand while meeting the requirements.
1 participant
fix: After renaming the predecessor node, the variable list was not updated