Skip to content

fix: Add trigger permissions #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Feb 2, 2026
Merged

fix: Add trigger permissions #4753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion apps/trigger/views/trigger_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
from drf_spectacular.utils import extend_schema
from rest_framework.request import Request
from rest_framework.views import APIView

from common.auth.authentication import has_permissions
from common import result
from trigger.api.trigger_task import TriggerTaskRecordExecutionDetailsAPI, TriggerTaskRecordPageAPI, TriggerTaskAPI
from trigger.serializers.trigger_task import TriggerTaskQuerySerializer, TriggerTaskRecordQuerySerializer, \
TriggerTaskRecordOperateSerializer
from common.constants.permission_constants import PermissionConstants, RoleConstants, ViewPermission, CompareConstants, \
Permission, Group, Operate


class TriggerTaskView(APIView):
Expand All @@ -27,6 +29,10 @@ class TriggerTaskView(APIView):
responses=TriggerTaskAPI.get_response(),
tags=[_('Trigger')] # type: ignore
)
@has_permissions(
PermissionConstants.TRIGGER_READ.get_workspace_permission_workspace_manage_role(),
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
)
def get(self, request: Request, workspace_id: str, trigger_id: str):
return result.success(
TriggerTaskQuerySerializer(data={'workspace_id': workspace_id, 'trigger_id': trigger_id}).list())
Expand All @@ -46,6 +52,10 @@ class TriggerTaskRecordExecutionDetailsView(APIView):
responses=TriggerTaskRecordExecutionDetailsAPI.get_response(),
tags=[_('Trigger')] # type: ignore
)
@has_permissions(
PermissionConstants.TRIGGER_READ.get_workspace_permission_workspace_manage_role(),
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
)
def get(self, request: Request, workspace_id: str, trigger_id: str, trigger_task_id: str,
trigger_task_record_id: str):
return result.success(
Expand All @@ -65,6 +75,10 @@ class TriggerTaskRecordPageView(APIView):
responses=TriggerTaskRecordPageAPI.get_response(),
tags=[_('Trigger')] # type: ignore
)
@has_permissions(
PermissionConstants.TRIGGER_READ.get_workspace_permission_workspace_manage_role(),
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
)
def get(self, request: Request, workspace_id: str, trigger_id: str, current_page: int, page_size: int):
return result.success(
TriggerTaskRecordQuerySerializer(
Expand Down