fix: Tool workflow restricts the deletion of basic nodes and start nodes#4960
fix: Tool workflow restricts the deletion of basic nodes and start nodes#4960shaohuzhang1 merged 1 commit intov2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| 'tool-base-node', | ||
| 'base-node', | ||
| 'loop-body-node', | ||
| 'loop-start-node', |
There was a problem hiding this comment.
The code looks generally correct, but there are a few small improvements you could make:
-
Remove Duplicates: The array
['start-node', 'tool-base-node']contains duplicate entries. You should remove one of them to avoid redundancy. -
Improve Readability: Consider grouping similar node types together if they share common functionalities or properties.
Here's the updated code with these changes applied:
@@ -104,6 +104,8 @@ export function initDefaultShortcut(lf: LogicFlow, graph: GraphModel) {
const nodes = elements.nodes.filter((node) =>
[
'start-node',
+ 'tool-start-node', // Removed duplicate entry
+ 'tool-base-node', // Added back only once
'base-node',
'loop-body-node',
'loop-start-node',These changes help maintain clarity in the list and ensure no unnecessary duplicates exist.
fix: Tool workflow restricts the deletion of basic nodes and start nodes